-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0 #809
Version 1.0 #809
Conversation
Do we want #800 after this release? |
Have followed up against that discussion. |
… could change across package versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change the error message in https://github.com/encode/httpcore/pull/809/files#diff-5bb436aadeb1bfe2f41078fe8d1a4db589eb3405df644e07ce5e26c7749da824R40 to something like Running under trio requires the 'httpcore' to be installed with the 'trio' extra.
because when the user has trio installed, the current message doesn't make any sense.
Why would that error be displayed when trio is installed? |
When the trio is installed but the sniffio isn't |
Resolved |
I think we're good to go here... I'll plan on releasing this tomorrow. |
Do we want to include #799 to 1.0.0? |
Ok. |
Release date 🥶 |
Oops. (thanks) |
On that note, how are you creating your GitHub releases? I don't see any automation. |
Copy the release notes. Yup some buttons do get pressed through the GitHub UI. |
In case you're interested, here's how I handle things: https://github.com/agronholm/anyio/blob/master/.github/workflows/publish.yml |
Proposal for
httpcore
version 1.0.Our API is already stable, and I don't think we've any blockers that ought to prevent us issuing a 1.0 release.
The one change that I am suggesting in this pull request is that we switch to a more minimal set of default dependancies, by making the async case fully optional. We've already done the work on making these packages not strictly required. This proposal builds on that work by no longer installing
anyio
/sniffio
/trio
by default.TODO:
See also encode/httpx#947.