Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #176 inspired by a comment from @tomchristie
I quite like this approach, it's nice and simple. I only see two caveats:
next_dispatcher
as an argument. It's not really a problem, just find the fact that we're deriving fromAsyncDispatch
when we're actually using duck/structural typing a bit misleading. Maybe we could formalize it somehow?send
arguments. That being said the auth logic is probably a lot more complicated than other usages we might have.I'm keen to hear if this approach would help implementing features like proxy support. I think redirection and auth look a lot simpler this way.