Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.25.0 #2801

Merged
merged 17 commits into from
Sep 11, 2023
Merged

Version 0.25.0 #2801

merged 17 commits into from
Sep 11, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Aug 1, 2023

0.25.0 (11th Sep, 2023)

Removed

Added

Fixed

@trim21 trim21 marked this pull request as ready for review August 1, 2023 10:25
@tomchristie
Copy link
Member

Okay, let's...

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Kar Petrosyan <92274156+karosis88@users.noreply.github.com>
@trim21
Copy link
Contributor Author

trim21 commented Aug 1, 2023

  • Ensure that the PR description matches the style we're using for release PRs.

does this mean to simply copy changelog of this version as PR description?

Justify to ourselves if we should be issuing a minor point release or a media point release? Which one and why?

Not sure you are asking me or the maintainers, I have no opinion on this.

@karpetrosyan
Copy link
Member

Can we assume that the current version of httpcore is the last one that we will be able to support in this release? Because httpcore changed the response.extensions type in encode/httpcore#762 I'm guessing we'll have type issues with the next httpcore release.

@tomchristie
Copy link
Member

tomchristie commented Aug 1, 2023

does this mean to simply copy changelog of this version as PR description?

Yep.

I have no opinion on this.

For the 0.x series we're using median point bumps for releases that include API changes. We've only got additions and fixes here, so we probably want a 0.24.2 release?

@tomchristie
Copy link
Member

I'm guessing we'll have type issues with the next httpcore release.

I'm... not sure if the Mapping -> MutableMapping switch-up will cause a continuous integration issue or not.
It's not an issue in practise, because we're actually using dictionary instances throughout anyways. But it might cause a typing problem?

You could issue a draft PR where httpcore installs from the repo source if you wanted to double check.

@trim21
Copy link
Contributor Author

trim21 commented Aug 1, 2023

For the 0.x series we're using median point bumps for releases that include API changes. We've only got additions and fixes here, so we probably want a 0.24.2 release?

I'll update the version number according your discussion and decision 🙂

@trim21
Copy link
Contributor Author

trim21 commented Aug 7, 2023

I'm guessing we'll have type issues with the next httpcore release.

I'm... not sure if the Mapping -> MutableMapping switch-up will cause a continuous integration issue or not. It's not an issue in practise, because we're actually using dictionary instances throughout anyways. But it might cause a typing problem?

You could issue a draft PR where httpcore installs from the repo source if you wanted to double check.

I think if we want to include #2794, we should create a httpcore release (>=0.18.0) first, require master branch of httpcore is not a good idea.

@tomchristie
Copy link
Member

tomchristie commented Aug 8, 2023

I think if we want to include #2794, we should create a httpcore release (>=0.18.0) first

Indeed, yep.

I think the TODO list here looks like this(?)...

@trim21
Copy link
Contributor Author

trim21 commented Aug 8, 2023

Drop Python 3.7 from httpcore/httpx.

This doesn't need to be in todo list I think, we can drop them later

@Pliner
Copy link
Contributor

Pliner commented Aug 9, 2023

@trim21 Could you please include #2813 into this release? I merged it to master today morning.

@trim21
Copy link
Contributor Author

trim21 commented Aug 9, 2023

For the 0.x series we're using median point bumps for releases that include API changes. We've only got additions and fixes here, so we probably want a 0.24.2 release?

Now we removed python3.7 support, I think it's definitely 0.25.0 not 0.24.2

@trim21 trim21 mentioned this pull request Aug 9, 2023
1 task
@trim21
Copy link
Contributor Author

trim21 commented Sep 11, 2023

@tomchristie now todo list is empty

@tomchristie tomchristie merged commit c3585a5 into encode:master Sep 11, 2023
4 checks passed
@trim21 trim21 deleted the release-0.25.0 branch September 11, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants