Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types-certifi and types-chardet are no longer needed #3015

Merged
merged 1 commit into from
Dec 21, 2023
Merged

types-certifi and types-chardet are no longer needed #3015

merged 1 commit into from
Dec 21, 2023

Conversation

mtelka
Copy link
Contributor

@mtelka mtelka commented Dec 21, 2023 •
edited
Loading

Summary

Both certifi and chardet now contains typing info so we no longer need types-certifi and types-chardet.
See also #3014

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

tomchristie
tomchristie approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks.

@tomchristie tomchristie merged commit 1d526a0 into encode:master Dec 21, 2023
5 checks passed
@tomchristie tomchristie added the tooling Changes to our CI/CD, tests setup, etc. label Dec 21, 2023
@mtelka mtelka deleted the types branch December 21, 2023 10:56
@T-256 T-256 mentioned this pull request Feb 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
tooling Changes to our CI/CD, tests setup, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtelka @tomchristie