-
-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass usedforsecurity to hashlib.md5 to fix error on FIPS-enabled systems #1366
fix: pass usedforsecurity to hashlib.md5 to fix error on FIPS-enabled systems #1366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I wasn't sure about: do we want a test that monkey patches hashlib
to verify that we are passing usedforsecurity=False
? Seems like overkill to me
@adriangb Fantastic, thanks! I've invited you as a maintainer, so that you can merge this PR yourself. |
Worked perfectly, thank you Tom |
Closes #1365