Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collect routes from Host(#2118) #2183

Merged
merged 3 commits into from Jun 13, 2023
Merged

Conversation

magiskboy
Copy link
Contributor

Summary

When developer defines Host in application, routes of Host cannot be generated to OpenAPI schemas so this PR fixes that.

I collect routes (in get_endpoints) in Host class when generating OpenAPI schemas

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@magiskboy magiskboy changed the title fix: collect routes from Host(2118) fix: collect routes from Host(#2118) Jun 12, 2023
@magiskboy magiskboy marked this pull request as draft June 12, 2023 22:36
@magiskboy magiskboy marked this pull request as ready for review June 12, 2023 22:54
@Kludex
Copy link
Sponsor Member

Kludex commented Jun 13, 2023

Thanks @magiskboy :)

@Kludex Kludex enabled auto-merge (squash) June 13, 2023 06:22
@Kludex Kludex merged commit 1c1043c into encode:master Jun 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants