Add type hints to test_authentication.py
#2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechNiick
changed the title
test_authentication.py
Kludex
changed the title
test_authentication.pytest_authentication.py
Kludex
requested changes
Feb 5, 2024
| @@ -1,9 +1,16 @@ | |||
| import base64 | |||
| import binascii | |||
| import sys | |||
| from typing import Any, Awaitable, Callable, Optional, Tuple | |||
There was a problem hiding this comment.
Let's avoid use Any, please.
tests/test_authentication.py
Outdated
| from starlette.testclient import TestClient | ||
| from starlette.websockets import WebSocket, WebSocketDisconnect | ||
|
|
||
| P = ParamSpec("P") |
There was a problem hiding this comment.
Yes, I have added it on **kwargs: P.kwargs.
…ick/starlette into improve-types/test_authentication
Kludex
reviewed
Feb 6, 2024
tests/test_authentication.py
Outdated
| def ws_inject_decorator(**kwargs): | ||
| def wrapper(endpoint): | ||
| def app(websocket): | ||
| def ws_inject_decorator(**kwargs: P.kwargs) -> Callable[..., AsyncEndpoint]: # type: ignore |
There was a problem hiding this comment.
Suggested change
| def ws_inject_decorator(**kwargs: P.kwargs) -> Callable[..., AsyncEndpoint]: # type: ignore | |
| def ws_inject_decorator(**kwargs: Any) -> Callable[..., AsyncEndpoint]: |
Kludex
approved these changes
Feb 6, 2024
nixroxursox
pushed a commit
to nixroxursox/starlette
that referenced
this pull request
Mar 18, 2024
* added type annotations to test_authentication.py * fixed types * Apply suggestions from code review * Fix linting * Fix linting * Apply suggestions from code review --------- Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan> Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to this
Type annotation added to
test_authentication.pyChecklist