Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not unquote path #354

Closed
wants to merge 1 commit into from
Closed

Do not unquote path #354

wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 1, 2019

If /foo%2Fbar is requested, it should be passed on like that.

It is the responsibility of the app to do any encoding (if wanted), and
currently prevents to get the raw value.

Found only b420242 quickly in this regard.

If `/foo%2Fbar` is requested, it should be passed on like that.

It is the responsibility of the app to do any encoding (if wanted), and
currently prevents to get the raw value.
@blueyed
Copy link
Contributor Author

blueyed commented May 1, 2019

hypercorn is also doing this.. I hope it is not in the spec - but could not find something about it in asgiref.

@tomchristie
Copy link
Member

Spec is here: https://asgi.readthedocs.io/en/latest/specs/www.html#http

path (Unicode string) – HTTP request target excluding any query string, with percent-encoded sequences and UTF-8 byte sequences decoded into characters.

Same as with WSGI.

@blueyed
Copy link
Contributor Author

blueyed commented May 1, 2019

Ok, created django/asgiref#87.

What about a test covering this? :)

@blueyed blueyed deleted the no-unquote branch May 1, 2019 21:56
@blueyed
Copy link
Contributor Author

blueyed commented May 2, 2019

Also a duplicate of #261 - so at least somebody else cares.. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants