Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scope["raw_path"] for both HTTP and websockets #372

Merged
merged 5 commits into from
Jun 18, 2019

Conversation

simonw
Copy link
Contributor

@simonw simonw commented Jun 16, 2019

As discussed in django/asgiref#87 and implemented in django/asgiref#92

The PR adding raw_path to the ASGI specification will hopefully be merging very shortly. This change to Uvicorn should be considered blocked until the specification has been updated.

@simonw simonw changed the title Implemented scope["raw_path"] for both HTTP and websockets Implement scope["raw_path"] for both HTTP and websockets Jun 16, 2019
@simonw
Copy link
Contributor Author

simonw commented Jun 16, 2019

Previously discussed in #261 and #354 - but that was before the change to the ASGI specification.

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crackin' stuff! Suggested a few tiny tweaks.

tests/protocols/test_websocket.py Outdated Show resolved Hide resolved
tests/protocols/test_http.py Outdated Show resolved Hide resolved
tests/protocols/test_http.py Outdated Show resolved Hide resolved
@tomchristie
Copy link
Member

Really nice to see that supporting this actually needs almost no extra implementation.

@simonw
Copy link
Contributor Author

simonw commented Jun 17, 2019

The specification has now been updated to add raw_path: django/asgiref#92

@tomchristie tomchristie merged commit 184fb41 into encode:master Jun 18, 2019
@tomchristie
Copy link
Member

Released as 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants