Added cli suport for headers containing colon #813
Conversation
Some http headers need to have colon in its values, such as: ``` Content-Security-Policy: default-src 'self'; script-src https://example.com; ``` Passing this value though the client used to raise an error, because this header would be parsed as: ``` ["Content-Security-Policy", "default-src 'self'; script-src https", "//example.com;"] ``` And could no be unpached as key, value pair. This commit limits the spliting on colon to its first occuence in the string, enabling us to pass a value containing semicolon in the cli: ``` $ uvicorn main:app --header 'Content-Security-Policy:default-src *:8000' ```
|
@euri10 changes applied! Tell me what you think and I can open another PR by this week (I didn't find where to test it yet) |
I dont think that's necessary, I just looked briefly but it seems to me we get key / value in Config from maiin so the strip is not necessary since it will have happened already with this fix, but I can mix up things .) If that's not the case then writing a failing test will make it obvious. |
|
thanks @romulocollopy ! |
my pleasure =) |
Some http headers need to have colon in its values, such as:
Passing this value though the client used to raise an error, because this
header would be parsed as:
And could no be unpached as key, value pair.
This commit limits the spliting on colon to its first occuence in the string,
enabling us to pass a value containing semicolon in the cli: