Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase coverage by testing for an invalid http request #857

Merged
merged 2 commits into from
Dec 12, 2020
Merged

Increase coverage by testing for an invalid http request #857

merged 2 commits into from
Dec 12, 2020

Conversation

euri10
Copy link
Member

@euri10 euri10 commented Nov 19, 2020

simply trying to increase coverage

@euri10 euri10 mentioned this pull request Dec 12, 2020
Merged
florimondmanca
florimondmanca approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Neat. I have follow-up suggestions but I'll issue a new PR on top of this one :-)

tests/protocols/test_http.py Outdated Show resolved Hide resolved
@florimondmanca florimondmanca merged commit 5512965 into encode:master Dec 12, 2020
@euri10 euri10 deleted the invalid_request branch December 12, 2020 13:21
@florimondmanca florimondmanca mentioned this pull request Dec 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@euri10 @florimondmanca