Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't perform meetup because "claimant not part of same meetup" #374

Closed
brenzi opened this issue Feb 17, 2022 · 8 comments · Fixed by #386 or #391
Closed

can't perform meetup because "claimant not part of same meetup" #374

brenzi opened this issue Feb 17, 2022 · 8 comments · Fixed by #386 or #391
Labels
bug Something isn't working

Comments

@brenzi
Copy link
Member

brenzi commented Feb 17, 2022

Trying to perform a meetup with 3 or 4 phones, but when I scan other claims, it often tells me that the claimant is not part of the same meetup.

evidence:
image

two phones, both registered to the same meetup (checked the registry and there is only one location anyway)

I suspect a cache inconsistency, like cindex out of date or some other parameter which leads to a wrong calculation of mindex or whatecer claim input

possibly connected to #357 ?

@brenzi brenzi added the bug Something isn't working label Feb 17, 2022
@clangenb
Copy link
Member

clangenb commented Feb 20, 2022

This is very interesting. Here is the diff of the two QR-codes:

image

The only difference is the public key and the signature. Hence, if both are really registered in the meetup, which @brenzi seems to have verified, they should both be valid.

However: On my first try while scanning the above codes, there was still the mouse-pointer in the image, and there was a successful scan, but the decoding of the claim failed then. Hence, the QR-Scanner successfully scanned an erroneous QR-Code. I wonder if the issue is related to an erroneous scan.

@clangenb
Copy link
Member

clangenb commented Feb 20, 2022

@clangenb
Copy link
Member

It seems there was a misunderstanding, the error was thrown in the app and not onchain, namely:

if (!store.encointer.meetupRegistry.contains(claim.claimantPublic)) {

@brenzi brenzi reopened this Feb 20, 2022
@clangenb
Copy link
Member

As a worst-case scenario, we can remove the app-side check, as the claim seems to be OK.

@brenzi
Copy link
Member Author

brenzi commented Feb 20, 2022

Full error log of the scanning phone that says claimant not from asame meetup:
https://gist.github.com/brenzi/14c90d8d190ac192be6843a698f8a721

@brenzi
Copy link
Member Author

brenzi commented Feb 20, 2022

noteworthy:

I/flutter ( 3793): received msg: {"path":"uid=21;encointer.getMeetupRegistry","data":["5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM","5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM","5F77sGnUhpjdFnzruhurGZgqPFtvdECXTGgX4Bgy2zGavbEw","5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM","5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM","5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM","5FyWbcwN1TGPdyzRzoEeem3MUcc7jXRs7ZoftZkAQLV47nS7","5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM","5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM","5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM"]}
I/flutter ( 3793): api: Participants: [5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5F77sGnUhpjdFnzruhurGZgqPFtvdECXTGgX4Bgy2zGavbEw, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5FyWbcwN1TGPdyzRzoEeem3MUcc7jXRs7ZoftZkAQLV47nS7, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM]
I/flutter ( 3793): store: set meetupRegistry to [5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5F77sGnUhpjdFnzruhurGZgqPFtvdECXTGgX4Bgy2zGavbEw, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5FyWbcwN1TGPdyzRzoEeem3MUcc7jXRs7ZoftZkAQLV47nS7, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM]
I/flutter ( 3793): store: set meetupRegistry to [5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5F77sGnUhpjdFnzruhurGZgqPFtvdECXTGgX4Bgy2zGavbEw, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5FyWbcwN1TGPdyzRzoEeem3MUcc7jXRs7ZoftZkAQLV47nS7, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM]
I/flutter ( 3793): received msg: {"path":"uid=45;codec.decode","data":{"claimantPublic":"5GjnBkWthQqmfxL35A2sY9QeTky33bENo5zbLxh7KsY5wo5L","ceremonyIndex":308,"communityIdentifier":{"geohash":"0x7530716a39","digest":"0xabb12168"},"meetupIndex":1,"location":{"lat":"0x0000568a353db7632f00000000000000","lon":"0x0000000000095b840800000000000000"},"timestamp":1645434955917,"numberOfParticipantsConfirmed":3,"claimantSignature":{"sr25519":"0x06f6032817238e945e322ef4f5084b7664d4cbc2f88579a422e37dec8f08646931b24e0d7fa71718ccda095a04807be8e7c2e465ec06331e9fa69c3df83dfa8a"}}}

So the app thinks this is the meetup registry:

  • 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM
  • 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM
  • 5F77sGnUhpjdFnzruhurGZgqPFtvdECXTGgX4Bgy2zGavbEw
  • 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM
  • 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM
  • 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM
  • 5FyWbcwN1TGPdyzRzoEeem3MUcc7jXRs7ZoftZkAQLV47nS7
  • 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM
  • 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM
  • 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM

The account 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM is not even part of the bootstrappers:

./encointer-client-notee list-meetups --cid u0qj95PYNyD
listing meetups for cid u0qj95PYNyD and ceremony nr 309
number of meetups assigned:  1
MeetupRegistry[(u0qj95PYNyD, 309), 1] location is Location { lat: 47.3895147567476087147, lon: 8.5170140862464904785 }
MeetupRegistry[309, 1] meeting time is Ok(1645436880000)
MeetupRegistry[(u0qj95PYNyD, 309), 1] participants are:
   5E6x8Z6R7fYeTETj8Em5pDazcodq6Krjig5gxkSuQEvj6evv
   5GjnBkWthQqmfxL35A2sY9QeTky33bENo5zbLxh7KsY5wo5L
   5ChwkE8kd2qagyiCikP2Ns2T6vWh7dbURx54gXcPKw8NotNp
   5FEkyAfUWXwA4jdsm88kMzhF7VAenxuwZtwNs9RzeFRjXGcS
   5F77sGnUhpjdFnzruhurGZgqPFtvdECXTGgX4Bgy2zGavbEw
   5GNdoaiCrGU9G9zz694d1S3XPov6Ji3zo6NR7nN2tH7jtK7Z
   5DPgv6nn4R1Gi1MUiAnzFDPaKF56SYKD9Zq4Q6REUGLhUZk1
   5FyWbcwN1TGPdyzRzoEeem3MUcc7jXRs7ZoftZkAQLV47nS7
   5CMVLJCC4Jn7QmLsFRkLWkm2w4LJswpZo1V2nd1tp64iVnCR
   5DCr4Xh5pFCRHZQhvteNbdzH5bD68b5VFhAkunF7gW9umwkf

So yes, if that would be the meetup registry, the app would correctly mourn that the claimant is not from this meetup, as the

claimant is:

I/flutter ( 3793): received msg: {"path":"uid=45;codec.decode","data":{"claimantPublic":"5GjnBkWthQqmfxL35A2sY9QeTky33bENo5zbLxh7KsY5wo5L","ceremonyIndex":308,"communityIdentifier":{"geohash":"0x7530716a39","digest":"0xabb12168"},"meetupIndex":1,"location":{"lat":"0x0000568a353db7632f00000000000000","lon":"0x0000000000095b840800000000000000"},"timestamp":1645434955917,"numberOfParticipantsConfirmed":3,"claimantSignature":{"sr25519":"0x06f6032817238e945e322ef4f5084b7664d4cbc2f88579a422e37dec8f08646931b24e0d7fa71718ccda095a04807be8e7c2e465ec06331e9fa69c3df83dfa8a"}}}

by the way: the scanner isn't part of that meetup neither ;-) :5ChwkE8kd2qagyiCikP2Ns2T6vWh7dbURx54gXcPKw8NotNp

I/flutter ( 3793): received msg: {"path":"uid=40;encointer.signClaimOfAttendance","data":{"claimantPublic":"5ChwkE8kd2qagyiCikP2Ns2T6vWh7dbURx54gXcPKw8NotNp","ceremonyIndex":308,"communityIdentifier":{"geohash":"0x7530716a39","digest":"0xabb12168"},"meetupIndex":1,"location":{"lat":"0x0000568a353db7632f00000000000000","lon":"0x0000000000095b840800000000000000"},"timestamp":1645434955917,"numberOfParticipantsConfirmed":3,"claimantSignature":{"sr25519":"0x2260924e6d9923091be897e4624027c4b97699fbff872effffb033fd4d51e31ad0c6303629c7868f20dd8d49141577dbc11b38f62a8ac4041c9d37744613d78e"}}}

So, @clangenb I think you may never be able to reproduce this if you only test locally with Alice, Bob and Charlie.
Please test on Gesell, using three bootstrapper phones with the accounts I supplied

@brenzi
Copy link
Member Author

brenzi commented Feb 20, 2022

tried one ceremony later:

I/flutter ( 8690): store: set meetupRegistry to [5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5F77sGnUhpjdFnzruhurGZgqPFtvdECXTGgX4Bgy2zGavbEw, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5FyWbcwN1TGPdyzRzoEeem3MUcc7jXRs7ZoftZkAQLV47nS7, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM, 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM]

not exactly the same, but the error is reproducible

@brenzi
Copy link
Member Author

brenzi commented Feb 21, 2022

Please simply make the meetup participant check a warning, but ignore it. #390 shall solve this properly. And close this issue when done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants