Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade registrations and unregister #254

Merged
merged 11 commits into from Aug 16, 2022
Merged

Upgrade registrations and unregister #254

merged 11 commits into from Aug 16, 2022

Conversation

pifragile
Copy link
Contributor

@pifragile pifragile mentioned this pull request Aug 10, 2022
Closed
clangenb
clangenb requested changes Aug 14, 2022
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very good stuff going on here!

I do have some remarks though. :)

ceremonies/src/lib.rs Show resolved Hide resolved
ceremonies/src/lib.rs Outdated Show resolved Hide resolved
ceremonies/src/lib.rs Outdated Show resolved Hide resolved
ceremonies/src/lib.rs Outdated Show resolved Hide resolved
ceremonies/src/lib.rs Outdated Show resolved Hide resolved
ceremonies/src/tests.rs Outdated Show resolved Hide resolved
ceremonies/src/tests.rs Show resolved Hide resolved
ceremonies/src/tests.rs Outdated Show resolved Hide resolved
ceremonies/src/tests.rs Show resolved Hide resolved
clangenb
clangenb reviewed Aug 15, 2022
View reviewed changes
ceremonies/src/lib.rs Outdated Show resolved Hide resolved
ceremonies/src/lib.rs Outdated Show resolved Hide resolved
ceremonies/src/lib.rs Outdated Show resolved Hide resolved
clangenb
clangenb approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fixes. It looks very clean!

@clangenb clangenb merged commit 45f328c into master Aug 16, 2022
@clangenb clangenb deleted the upgrade-reputations branch October 29, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow to update ceremony registration
2 participants
@pifragile @clangenb