Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark upgrade_registration and unregister #247

Closed
wants to merge 1 commit into from

Conversation

pifragile
Copy link
Contributor

Benchmarks for encointer/pallets#254

@brenzi
Copy link
Member

brenzi commented Aug 20, 2022

I think we need a different process for benchmarks than such PR's. same machine always, alerts upon significant weight changes....

I now just copy-pasted weights from pallets into #248. not the clean approach as its also not the right PR, but if we want to keep node and pallet in different repositories, it's too much hassle to review and test every PR with its counterpart on this repo

@brenzi
Copy link
Member

brenzi commented Aug 22, 2022

I'll close it as #248 includes benchmarks

@brenzi brenzi closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants