Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'application.path' resolves to sa.core.dll instead of sa.shellextension.dll #124

Closed
end2endzone opened this issue May 31, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@end2endzone
Copy link
Owner

Describe the bug
Property application.path resolves to sa.core.dll instead of sa.shellextension.dll.
The UserManual states that property application.path should "Matche the full path of the shell extension DLL."

To Reproduce
Steps to reproduce the behavior:

  1. Load the shell extension.
  2. Create the following menu:
<menu name="Debug">
  <menu name="${application.path}">
  </menu>
</menu>
  1. Right-click on File Explorer, the shell extension's menus will be displayed.
  2. Look at the name of the menu displayed under menu Debug.

Expected behavior
Property application.path should be set to something similar to C:\Program Files\ShellAnything\bin\sa.shellextension.dll.

Screenshots
N/A

Environment

  • OS: Windows 10

Additional context
N/A

@end2endzone end2endzone added the bug Something isn't working label May 31, 2023
@end2endzone
Copy link
Owner Author

This bug was certainly introduced when the code has migrated from a single static dll to multiple dynamic dll.

@end2endzone end2endzone added this to the 0.8.0 milestone May 31, 2023
end2endzone added a commit that referenced this issue Jul 3, 2023
@end2endzone
Copy link
Owner Author

Fixed in 73d2757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant