Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a <message> action to show a simple popup message #40

Closed
end2endzone opened this issue Apr 14, 2020 · 2 comments
Closed

Create a <message> action to show a simple popup message #40

end2endzone opened this issue Apr 14, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@end2endzone
Copy link
Owner

end2endzone commented Apr 14, 2020 •
edited
Loading

This feature could be useful to show a confirmation message following another action.
For example:

  <message title="Created configuration file '${config_file_path}' without error." icon="information" />

Possible values for icon attribute should match "positive" icons of MessageBox() function:

  • information (default)
  • exclamation
  • none

The 'error' value and error icons shall not be supported since when an executed action returns an error, the following action (in this case a <message>) will not be executed.

The question icon shall not be supported since it is associated with a <prompt> action.
@end2endzone end2endzone added enhancement New feature or request invalid This doesn't seem right labels Apr 14, 2020
@end2endzone
Copy link
Owner Author

The feature is already implemented in <prompt> action with type attribute OK.

@end2endzone end2endzone removed the enhancement New feature or request label Apr 17, 2020
@end2endzone end2endzone reopened this Apr 17, 2020
@end2endzone
Copy link
Owner Author

Reopening the issue. The <message> action is more elaborate than the <prompt> action. It is already clearer to the user.

@end2endzone end2endzone added enhancement New feature or request and removed invalid This doesn't seem right labels Apr 17, 2020
@end2endzone end2endzone changed the title Create a 'message' action to show a simple popup message Create a <message> action to show a simple popup message Apr 19, 2020
end2endzone added a commit that referenced this issue Apr 19, 2020
@end2endzone
Fixed issue #40: Create a <message> action to show a simple popup mes…
6747249 
…sage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@end2endzone