Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github don't identify the repository LICENSE as MIT. #66

Closed
end2endzone opened this issue Aug 8, 2020 · 3 comments
Closed

Github don't identify the repository LICENSE as MIT. #66

end2endzone opened this issue Aug 8, 2020 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@end2endzone
Copy link
Owner

Github do not identify the license of the application as MIT. This is observable when looking at the main application page as it says View license next to the "justice" icon. It would normally say "MIT license".

I think this is because the repository contains multiple files called LICENSE:

  • LICENSE (the official license file)
  • LICENSE.h (the c++ template to use in source code files)
  • LICENSE.rtf (The license file used with the Wix Toolset, to build the installer)
@end2endzone end2endzone added the bug Something isn't working label Aug 8, 2020
@end2endzone
Copy link
Owner Author

I tried editing the LICENSE file directly on github and selected the MIT license as per these instructions. See commit 13ec8e0 for details. The issue was not resolved and github is still confused as to which license file is the real license.

@end2endzone
Copy link
Owner Author

The file LICENSE.h is a template required when CMake generates the files /build/include/shellanything/config.h and /build/include/shellanything/version.h. The code in CMakeLists.txt should be modified to use the official LICENSE file and wrap the content with c++ block comments such as :

/*
LICENSE TEXT HERE
*/

The license header in config,h and version.h would be different that other license headers but this is a minor defect to deal with.

This problem is also observed with other repositories such as RapidAssist.

@end2endzone
Copy link
Owner Author

The file LICENSE.rtf sould be moved to /resources/ directory as it is only required when building the Wix installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant