-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code style check into CI pipeline #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should squash similar commits with appropriate commit message.
This PR also closes #11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I Merged in #20 - You can rebase this and I can merge this in |
* master: Add support for prometheus/pushgateway:>=0.10 (endclothing#17) Introduce Continuous Integration (endclothing#20)
@NoelDavies done |
Ugh, the test are failing because #17 was merged without working CI, I'll try to fix it. |
Ah sorry mate. I'm just going through them as I can. |
@NoelDavies can you take a look at #22 and merge it? |
I'm sorry for confusion, tests are failing due to bug in guzzle in version below 6.3. I'm updating minimum guzzle version which fixes the issue. |
@NoelDavies it's now green, after merging this master branch builds will also become green. |
This would have to be a major version change as the dependency for guzzle changes. |
@NoelDavies It's a minor version change for guzzle which is backwards compatible, should also be a minor version for this package. Either way when using guzzle < 6.3 with current master it will not work, you will get the same error that was caught in tests. |
@NoelDavies can we merge this to get CI green again? |
Apologies I thought I'd merged this |
* master: Add code style check into CI pipeline (endclothing#21)
* master: Add code style check into CI pipeline (endclothing#21)
Adds checking of coding standard (PSR-12) as part of CI pipeline.
Resolves #18