Allow tests to be run in TeamCity without using Sauce Labs #6
Conversation
…S auto start is not always required when running locally
…to Phantom if running locally on build server
…dme.txt with sample configs
AliceWaddicor
changed the title
|
One comment r.e. naming - local_auto_start_iis, local_hide_iis, local_hide_command_prompt_window and related C# properties might be better named: auto_start_local_iis, hide_local_iis, hide_local_command_prompt_window |
| @@ -44,7 +44,12 @@ static TestEnvironment() | |||
|
|
|||
| private TestEnvironment() | |||
| { | |||
| var config = new FileInfo(TestContext.CurrentContext.TestDirectory + @"\WebsiteUnderTest\web_test.config.json"); | |||
| FileInfo config = new FileInfo(@"WebsiteUnderTest\web_test.config.json"); | |||
| if (!config.Exists) | |||
There was a problem hiding this comment.
This is one of those classic race condition problems with file manipulation. It is quite possible that the file will stop existing between that test and you then going and reading everything. Is the intent of this that you are looking for the file in the current location, or in the currently set test directory? Why can't you just use the second case all the time - is it something to do with running in a different environment. This is the kind of code that needs some comments to explain what is going on to maintainers.
…ation test to try out on build server
…exception only when setting configPath
Fix for issue #2.
Configuration changes to allow tests to be run on the build server against a deployed version of the site, without using Sauce Labs
readme.txt updates explaining the changes.