[Enhancement] Display Stars on the Galaxy Map

[Azure3141]

Feature

This PR addresses the feature requested by {{definitely so many people, please merge this Derpy I'm begging you}}

Summary

This is a complete rewrite of #7197, which I asked Derpy to close because I was too busy at the time to implement the changes he suggested.

This adds a new map display mode, toggleable via a button, that changes out the system rings at close zooms for star icons tied to each star definition. These automatically populate the map based on the contents of each system, with support for multi-star systems.

When the starry map mode is displayed, at close zooms the system rings become transparent and system colors (showing government, commodity prices, etc) are transferred to the system names instead, blended with the default system name color for visibility purposes. This goes away as you zoom out, with the system names becoming more grey and the rings returning to their full opacity.

The entire map mode can also be disabled by clicking the toggle button, which is located above the zoom buttons in the bottom right.

The new star icons are located in a new map folder inside images, and I've relocated the milky way sprite (but not the deprecated galaxy sprite for backwards compatibility) there.

Screenshots

Close in view with starry map on:

Another close in view with starry map on:

Close in view with starry map on and a commodity selected:

Zoomed out view with starry map on:

Zoomed out view with starry map on and a commodity selected:

Zoomed out view with starry map off (same as vanilla):

Usage examples

A star (as in stars.txt) can have a n icon sprite defined for it using the icon attribute.

star "star/k-supergiant"
	power 1.8
	wind 3
	icon map/k-supergiant-star
star "star/m-supergiant"
	power 1.6
	wind 3.1
	icon map/m-supergiant-star

Testing Done

Looked at the map. Pressed the button. Saw stars.

Artwork Checklist

Will do laterz

• I updated the copyright attributions, or decline to claim copyright of any assets produced or modified
• I created a PR to the endless-sky-assets repo with the necessary image, blend, and texture assets: {{insert PR link}}
• I created a PR to the endless-sky-high-dpi repo with the @2x versions of these art assets: {{insert PR link}}

Performance Impact

Hopefully none? BatchShader is used to draw the star sprites so it shouldn't affect things too much, and I haven't noticed anything in testing.

[Tangle10]

This is a beautiful implementation of a sorely needed internal reference tool. Aside from its aesthetic value, without something like this the only ways to take advantage of systems with good solar power or solar wind are to memorize which ones are best or to make one's own map. As such, playstyles and ship designs reliant on solar power gain a path towards greater viability- and anyone needing a refuel doesn't have to go "wait, was Anbrim the supernova or Cshudlye?"

[mOctave]

Looking at your screenshots, I really like this. It's beautiful, it's useful, and have I mentioned that it's beautiful?

However:

1. Having the stars on in zoomed out view clutters the screen up a lot, and doesn't really add any value since in order to see the stars clearly I would need to have my eyes a centimetre away from my screen. The stars also overlap with the rings, which gets a little confusing. Maybe it would work better if the "ring" in this mode was an outline of the star that was a certain colour, although I don't think that would fix the busyness issue.
2. The coloured text is beautiful, but when it's an uninhabited system the grey seems more transparent than usual. As a result, it is difficult to read against the background. Perhaps uninhabited systems could use a lighter grey or even a white when star mode was enabled?
3. When the star sprites are large enough, they overlap with the text. This makes it even harder to read the text, especially since most of the systems with large stars are also uninhabited and therefore their names are harder to make out.

[Azure3141]

Having the stars on in zoomed out view clutters the screen up a lot, and doesn't really add any value since in order to see the stars clearly I would need to have my eyes a centimetre away from my screen. The stars also overlap with the rings, which gets a little confusing. Maybe it would work better if the "ring" in this mode was an outline of the star that was a certain colour, although I don't think that would fix the busyness issue.

I personally think it looks better, but that's what the toggle is for. I could maybe make the stars shrink more when zoomed out?

The coloured text is beautiful, but when it's an uninhabited system the grey seems more transparent than usual. As a result, it is difficult to read against the background. Perhaps uninhabited systems could use a lighter grey or even a white when star mode was enabled?

I've increased the opacity to see if that helps.

When the star sprites are large enough, they overlap with the text. This makes it even harder to read the text, especially since most of the systems with large stars are also uninhabited and therefore their names are harder to make out.

I've made the spacing scale with the number of stars in the system (which would result in an wider icon) to help alleviate this. This also stops trinary+ systems from becoming blobs with the new additive blending.

[Koranir]

• The star sprites are too bright compared to the text and everything else, add some transparency.
• If a system doesn't have a star sprite, it just disappears and leaves a conspicuous spot on the map.

I've opened a pull request on your repo that has fixes for these issues.

[Azure3141]

I've implemented those changes with some slight differences on my end (which is why I did it manually instead of via committing your PR)

The system ring now does not vanish if there is no star in that system. The stars also become more transparent when you zoom out, hopefully addressing @mOctave's concerns.

[Ferociousfeind]

All I'd want is a way to disable the rings, so I can just see the stars, the way apollo astronauts did not see any political borders, just the natural beauty of their pale blue dot. It would help with visually gauging distribution data, like where there are many bright stars, where there are many dim stars, how density and composition change in different places, where the interesting things even are...

[Koranir]

All I'd want is a way to disable the rings, so I can just see the stars, the way apollo astronauts did not see any political borders, just the natural beauty of their pale blue dot. It would help with visually gauging distribution data, like where there are many bright stars, where there are many dim stars, how density and composition change in different places, where the interesting things even are...

Perhaps we could have a third mode in which the stars are full alpha and there are no rings, maybe could reduce the transparency of the rest of the map elements as well.

[SomeTroglodyte]

Oh my, this is so beautiful I'll pull this, compile, and stop updating until the release notes mention it...

[quyykk]

Like leaf said, this should be a Sprite pointer and not a string. No use in passing strings around everywhere to then just get the Spriter pointer in the end anyways.

[bene-dictator]

(I'll do Ejo's job.) Code comments all look good.

[RisingLeaf]

smth like this

[RisingLeaf]

Suggested change

	static const vector<string> unmappedSystem = {"map/unexplored-star"};
	static const vector<const Sprite*> unmappedSystem = {SpriteSet::Get("map/unexplored-star")};

[RisingLeaf]

Suggested change

	starIcon[sprite] = child.Token(1);
	starIcon[sprite] = SpriteSet::Get(child.Token(1));