Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content: remove pirates from Ildaria #9809

Merged
merged 8 commits into from
May 1, 2024
Merged

Content: remove pirates from Ildaria #9809

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4a46cbb
temporarily remove the pirates during the sad archie mission
Hurleveur Feb 13, 2024
f4e73be
make it last a bit longer
Hurleveur Feb 13, 2024
f0ea033
dont increase the pirate spawn rates
Hurleveur Feb 13, 2024
29be0e6
dont change the time it takes in this PR
Hurleveur Feb 13, 2024
6ee21b7
initial deployment in case we want to care about it
Hurleveur Feb 13, 2024
f2b4941
forgot to remove this one
Hurleveur Feb 13, 2024
b034a6e
just remove pirates from Ildaria
Hurleveur Feb 17, 2024
260da88
post comp patch
Hurleveur Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion data/sheragi/archaeology missions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ mission "Deep Archaeology 5"
ship "Timer Ship"
attributes
"heat dissipation" 1
"hull" 3
"hull" 5
Hurleveur marked this conversation as resolved.
Show resolved Hide resolved
"hull repair rate" .001
"mass" 100
"drag" 5
Expand Down Expand Up @@ -332,11 +332,23 @@ outfit "Timer Submunition"
"hull damage" .15
"no damage scaling"

event "remove pirates from Ildaria"
system Ildaria
remove fleet "Small Southern Pirates"
remove fleet "Large Southern Pirates"

event "readd pirates to Ildaria"
system Ildaria
add fleet "Small Southern Pirates" 1000
add fleet "Large Southern Pirates" 2000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event "initial deployment 2" increases the periods of these fleets to 4000 and 7000, respectively. Applying this event after that will result in the pirate frequency in this system being almost four times what it is supposed to be.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
event "readd pirates to Ildaria"
system Ildaria
add fleet "Small Southern Pirates" 1000
add fleet "Large Southern Pirates" 2000
event "readd pirates to Ildaria"
system Ildaria
add fleet "Small Southern Pirates" 4000
add fleet "Large Southern Pirates" 7000

good catch, and there's no way you get this before said event so no need to have 2 different events

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did there might be riots before Geminus was bombed

Copy link
Member Author

@Hurleveur Hurleveur Feb 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's an edge case? I don't think it's worth it to have two events
We're talking about doing TMBR 1,2 and 3, meaning you'd need "Deep Archaeology 5" and going to hai space. Wouldn't happen except if you wanted it to

The one case where I could see adding a different event be worth it is if we make the start of the game happen earlier somehow
A second event wouldnt cost that much to add either (ultimately this just shows a lack of flexibility for events influencing fleet spawns)

Copy link
Contributor

@ziproot ziproot Feb 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The on complete block has a conversation, meaning the conversation can use a branch depending on whether or not initial deployment 2 has happened to determine whether or not to use an action to set one event or the other.
EDIT: Still, this is an issue where events can only override fleet spawns entirely, rather than revert the changes of a previous event.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean dont worry I know pretty much everything about data stuff after having done 10k lines of missions, it isn't about how to do it just whether or not it was worth it
I'll do it quickly and we'll see what warp thinks. It would be more robut tbf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw the tricky part here is to not have empty `` used as goto, but with branches it can be done

Copy link
Member Author

@Hurleveur Hurleveur Feb 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but just a word from the devs and I'll revert it as I'm not sure if we should be this precise with spawnrates

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, devs definitely override me.


mission "Sad Archie"
landing
invisible
to offer
has "There Might Be Riots part 3B: done"
on offer
event "remove pirates from Ildaria"
destination "Zug"

npc disable
Expand All @@ -352,6 +364,7 @@ mission "Sad Archie"
` Then you wake up and find yourself back in your ship, in the Ildaria system. Weird.`

on complete
event "readd pirates to Ildaria"
log `Experienced a strange vision while drifting in the Ildaria system that looked like the fall of a civilization of dragon-people. The terrain on the planet of Zug looks strikingly similar to this vision.`
conversation
`On a whim, as you're landing on Zug you pull up a geological map of the planet and find that the geography you dreamt of while drifting in the Ildaria system was surprisingly close to the real thing. There's even a massive basalt outcropping right where you saw a lava flow burying a city. There's no way your ship's sensors can tell what's underneath it, though.`
Expand Down
Loading