Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an Endless-key specific URI scheme #102

Closed
dylanmccall opened this issue Oct 4, 2023 · 1 comment · Fixed by #135
Closed

Use an Endless-key specific URI scheme #102

dylanmccall opened this issue Oct 4, 2023 · 1 comment · Fixed by #135
Assignees
@dylanmccall

Comments

@dylanmccall
Copy link
Contributor

The application uses two different custom URI schemes to refer to itself, x-kolibri-app: and x-kolibri-dispatch:. These should both be changed to use a prefix based on the app ID. For Endless Key, they should be x-endless-key-app: and x-endless-key-dispatch:.
@dylanmccall dylanmccall mentioned this issue Oct 4, 2023
Closed
@wjt
Copy link
Member

wjt commented Nov 21, 2023

As a result of both org.learningequality.Kolibri and org.endlessos.Key claiming to handle x-scheme-handler/x-kolibri-dispatch, it is nondeterministic which one will end up as the handler if you have both installed, and on my system Endless Key won. This means that the per-channel desktop launchers from Kolibri incorrectly launch Endless Key, which shows an error page.

@dylanmccall dylanmccall self-assigned this Nov 23, 2023
dylanmccall added a commit that referenced this issue Nov 23, 2023
@dylanmccall
Move app ID and prefixes to meson_options
5687969 
#102
dylanmccall added a commit that referenced this issue Nov 23, 2023
@dylanmccall
Generate URI schemes from build configuration
cbf311b 
#102
dylanmccall added a commit that referenced this issue Nov 23, 2023
@dylanmccall
Use a custom URI prefix for Endless Key
deb6e28 
#102
dylanmccall added a commit that referenced this issue Nov 24, 2023
@dylanmccall
Move app ID and prefixes to meson_options
72258b4 
#102
dylanmccall added a commit that referenced this issue Nov 24, 2023
@dylanmccall
Generate URI schemes from build configuration
e699a34 
#102
dylanmccall added a commit that referenced this issue Nov 24, 2023
@dylanmccall
Use a custom URI prefix for Endless Key
213a528 
#102
dylanmccall added a commit that referenced this issue Nov 24, 2023
@dylanmccall
Replace default build options
563da13 
#102
dylanmccall added a commit that referenced this issue Nov 24, 2023
@dylanmccall
Use a custom URI prefix for Endless Key
d1ef583 
Sometimes, the application uses custom URI schemes to communicate with
itself. In order to avoid conflicts with other versions of Endless Key
or Kolibri, prefix those URIs with a specific string set at build time.

#102
dylanmccall added a commit that referenced this issue Nov 24, 2023
@dylanmccall
Replace default build options
1232192 
Instead of relying on build configuration, patch the default values in
our downstream meson_options with an Endless Key-specific app ID, as
well as environment variable and URI scheme prefixes.

#102
@dylanmccall dylanmccall mentioned this issue Nov 24, 2023
Merged
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
@dylanmccall
Move app ID and prefixes to meson_options
ebb9eb1 
endlessm/endless-key-flatpak#102
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
@dylanmccall
Generate URI schemes from build configuration
18134c4 
endlessm/endless-key-flatpak#102
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 25, 2024
@dylanmccall
Move app ID and prefixes to meson_options
e9c94c6 
endlessm/endless-key-flatpak#102
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 25, 2024
@dylanmccall
Generate URI schemes from build configuration
0b637a2 
endlessm/endless-key-flatpak#102
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
@dylanmccall
Move app ID and prefixes to meson_options
5560081 
endlessm/endless-key-flatpak#102
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
@dylanmccall
Generate URI schemes from build configuration
8badd6e 
endlessm/endless-key-flatpak#102
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
@dylanmccall
Move app ID and prefixes to meson_options
76a8911 
endlessm/endless-key-flatpak#102
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
@dylanmccall
Generate URI schemes from build configuration
89fb3fc 
endlessm/endless-key-flatpak#102
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 23, 2024
@dylanmccall
Move app ID and prefixes to meson_options
b340e40 
endlessm/endless-key-flatpak#102
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 23, 2024
@dylanmccall
Generate URI schemes from build configuration
dcba3bf 
endlessm/endless-key-flatpak#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylanmccall dylanmccall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefix app-specific URL schemes to avoid conflicts endlessm/endless-key-flatpak
2 participants
@wjt @dylanmccall