Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix app-specific URL schemes to avoid conflicts #135

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

dylanmccall
Copy link
Contributor

Closes #102

Sometimes, the application uses custom URI schemes to communicate with
itself. In order to avoid conflicts with other versions of Endless Key
or Kolibri, prefix those URIs with a specific string set at build time.

#102
Instead of relying on build configuration, patch the default values in
our downstream meson_options with an Endless Key-specific app ID, as
well as environment variable and URI scheme prefixes.

#102
if build_profile == 'development'
base_application_id += '.Devel'
base_object_path += '/Devel'
profile_env_prefix += 'DEVEL_'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@starnight starnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@starnight starnight merged commit b201307 into main Nov 24, 2023
2 checks passed
@starnight starnight deleted the add-url-scheme-prefix branch November 24, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use an Endless-key specific URI scheme
2 participants