Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clubhouse: Fix vertical aligment of label notification #609

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Conversation

manuq
Copy link
Contributor

@manuq manuq commented Dec 27, 2019

The label bottom margin changed in commit 76bd3e8 from 25px to 30px
to consider the buttons below. But when there are no buttons, the text
looks misaligned.

https://phabricator.endlessm.com/T29046

The label bottom margin changed in commit 76bd3e8 from 25px to 30px
to consider the buttons below. But when there are no buttons, the text
looks misaligned.

https://phabricator.endlessm.com/T29046
Copy link
Contributor

@danigm danigm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikos erikos merged commit 5b3ce50 into master Jan 10, 2020
@erikos erikos deleted the T29046 branch January 10, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants