T31068 Support renaming Flatpaks #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See flatpak/flatpak@0772ab6 (cherry picked from commit 4fa6e66)
Using g_message() allows the log message to be formatted and redirected appropriately. (cherry picked from commit f89a291)
When an app is renamed, appropriate metadata is set server-side so that FlatpakTransaction::end-of-lifed-with-rebase is emitted. On the CLI the user can choose whether to install the renamed app. GNOME Software currently ignores the signal so such apps stay on their old names forever. This commit makes g-s follow such redirects and install the new app without user interaction, since that is what most users will want. A follow-up commit will add a message in the UI so the user can be informed in case the application's name is changing (as opposed to only the application ID changing, which shouldn't be user-visible). Note that in the special case where the installed commit is the one with the eol-rebase metadata (as opposed to being an older commit), such apps will not be returned by flatpak_installation_list_installed_refs_for_update() without this patch: flatpak/flatpak#3945 (cherry picked from commit c4c8086)
Currently for apps that have been renamed on Flathub, at least org.gnome.iagno for example, the appstream data only exists under the new name, so the app doesn't get properly displayed in the updates list as it should so it can be updated to the new name. Instead there are errors in the log "GsPluginFlatpak no match for ....: no results for XPath query" and later "Gs app invalid as no name ..." So use the appstream data under the new name in such circumstances. This is not perfect in that we'll show the new name before the app has actually been renamed, but it's certainly better than not showing the app at all, and in practice renames are often just to change the app ID. This makes renamed apps display properly in the Installed and Updates lists, but there is still a remaining issue: after updating an app to a new name, it doesn't show in the Installed list until after gnome-software is closed and restarted. (cherry picked from commit 3a14718)
Without a message the user may be confused why they can't find the app by looking for the name they remember. (cherry picked from commit 282e3ef)
|
These are clean cherry-picks from upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T31068