Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockscreen: Use retries default value #184

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

danigm
Copy link
Contributor

@danigm danigm commented Apr 17, 2019

Instead of use null as default value and then check that to assign the
default number we can use directly the default number in the function
declaration and remove the check.

Instead of use null as default value and then check that to assign the
default number we can use directly the default number in the function
declaration and remove the check.
Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@joaquimrocha
Copy link
Contributor

Thank you for doing this PR @danigm . Since we are in freeze, I don't know if we should merge this. The changes seem simple, but if we've tested the previous code very thoroughly already, I'd prefer not to risk it.
Summoning @cosimoc for a decision.

@cosimoc
Copy link
Contributor

cosimoc commented Apr 17, 2019

The original fix in https://phabricator.endlessm.com/T25728 was only merged yesterday, so I think this is a reasonable follow up. Let's get it in.

@cosimoc cosimoc merged commit e38cc9c into master Apr 17, 2019
@cosimoc cosimoc deleted the lockscreen-retries-use-default-value branch April 17, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants