Skip to content

Commit

Permalink
Merge branch 'kbuild' of git://git.kernel.org/pub/scm/linux/kernel/gi…
Browse files Browse the repository at this point in the history
…t/mmarek/kbuild

Pull kbuild changes from Michal Marek:
 - fix make -s detection with make-4.0
 - fix for scripts/setlocalversion when the kernel repository is a
   submodule
 - do not hardcode ';' in macros that expand to assembler code, as some
   architectures' assemblers use a different character for newline
 - Fix passing --gdwarf-2 to the assembler

* 'kbuild' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
  frv: Remove redundant debugging info flag
  mn10300: Remove redundant debugging info flag
  kbuild: Fix debugging info generation for .S files
  arch: use ASM_NL instead of ';' for assembler new line character in the macro
  kbuild: Fix silent builds with make-4
  Fix detectition of kernel git repository in setlocalversion script [take #2]
  • Loading branch information
torvalds committed Jan 31, 2014
2 parents 53d8ab2 + bf705ad commit 597690c
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 24 deletions.
8 changes: 7 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,15 @@ endif
# If the user is running make -s (silent mode), suppress echoing of
# commands

ifneq ($(filter 4.%,$(MAKE_VERSION)),) # make-4
ifneq ($(filter %s ,$(firstword x$(MAKEFLAGS))),)
quiet=silent_
endif
else # make-3.8x
ifneq ($(filter s% -s%,$(MAKEFLAGS)),)
quiet=silent_
endif
endif

export quiet Q KBUILD_VERBOSE

Expand Down Expand Up @@ -633,7 +639,7 @@ endif

ifdef CONFIG_DEBUG_INFO
KBUILD_CFLAGS += -g
KBUILD_AFLAGS += -gdwarf-2
KBUILD_AFLAGS += -Wa,--gdwarf-2
endif

ifdef CONFIG_DEBUG_INFO_REDUCED
Expand Down
2 changes: 2 additions & 0 deletions arch/arc/include/asm/linkage.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

#ifdef __ASSEMBLY__

#define ASM_NL ` /* use '`' to mark new line in macro */

/* Can't use the ENTRY macro in linux/linkage.h
* gas considers ';' as comment vs. newline
*/
Expand Down
7 changes: 0 additions & 7 deletions arch/frv/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,6 @@ KBUILD_CFLAGS += -mno-fdpic -mgpr-32 -msoft-float -mno-media
KBUILD_CFLAGS += -ffixed-fcc3 -ffixed-cc3 -ffixed-gr15 -ffixed-icc2
KBUILD_AFLAGS += -mno-fdpic

# make sure the .S files get compiled with debug info
# and disable optimisations that are unhelpful whilst debugging
ifdef CONFIG_DEBUG_INFO
#KBUILD_CFLAGS += -O1
KBUILD_AFLAGS += -Wa,--gdwarf2
endif

head-y := arch/frv/kernel/head.o

core-y += arch/frv/kernel/ arch/frv/mm/
Expand Down
8 changes: 0 additions & 8 deletions arch/mn10300/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,6 @@ define archhelp
echo '* zImage - Compressed kernel image (arch/$(ARCH)/boot/zImage)'
endef

# If you make sure the .S files get compiled with debug info,
# uncomment the following to disable optimisations
# that are unhelpful whilst debugging.
ifdef CONFIG_DEBUG_INFO
#KBUILD_CFLAGS += -O1
KBUILD_AFLAGS += -Wa,--gdwarf2
endif

#
# include the appropriate processor- and unit-specific headers
#
Expand Down
19 changes: 12 additions & 7 deletions include/linux/linkage.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
#include <linux/export.h>
#include <asm/linkage.h>

/* Some toolchains use other characters (e.g. '`') to mark new line in macro */
#ifndef ASM_NL
#define ASM_NL ;
#endif

#ifdef __cplusplus
#define CPP_ASMLINKAGE extern "C"
#else
Expand Down Expand Up @@ -75,21 +80,21 @@

#ifndef ENTRY
#define ENTRY(name) \
.globl name; \
ALIGN; \
name:
.globl name ASM_NL \
ALIGN ASM_NL \
name:
#endif
#endif /* LINKER_SCRIPT */

#ifndef WEAK
#define WEAK(name) \
.weak name; \
.weak name ASM_NL \
name:
#endif

#ifndef END
#define END(name) \
.size name, .-name
.size name, .-name
#endif

/* If symbol 'name' is treated as a subroutine (gets called, and returns)
Expand All @@ -98,8 +103,8 @@
*/
#ifndef ENDPROC
#define ENDPROC(name) \
.type name, @function; \
END(name)
.type name, @function ASM_NL \
END(name)
#endif

#endif
Expand Down
3 changes: 2 additions & 1 deletion scripts/setlocalversion
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ scm_version()
fi

# Check for git and a git repo.
if test -d .git && head=`git rev-parse --verify --short HEAD 2>/dev/null`; then
if test -z "$(git rev-parse --show-cdup 2>/dev/null)" &&
head=`git rev-parse --verify --short HEAD 2>/dev/null`; then

# If we are at a tagged commit (like "v2.6.30-rc6"), we ignore
# it, because this version is defined in the top level Makefile.
Expand Down

0 comments on commit 597690c

Please sign in to comment.