[toml syntax] Looks like netlify doesnt like our toml config's syntax #3409
Assignees
Labels
bug
Something isn't working
Comments
marcwrobel
added a commit
that referenced
this issue
Aug 19, 2023
Compared to the use of the validate.py script / validate.yaml workflow, this has the advantage of ensuring the validation is always performed. It also gives access to enriched data, which is useful for validated generated content, such as links. In addition to checks already implemented in the previous 'validate.py' script, this script: - Check that release dates are not too far in the future to avoid mistakes such as #3281 (max 30 days allowed). - Check all links are valid (even those in the products description). This check takes time and is not performed by default, but it can be triggered by setting the MUST_CHECK_URLS environment variable to true. To ensure links are regularly verified a new GitHub workflow, check-links.yml, has also been added. It runs every sunday at midnight. Note that: - Some links had to be excluded from the link validation because, despite being valid, they are sometime or systematically returning an error. - A dependency to open-uri (https://github.com/ruby/open-uri) has been added to simplify the validation of HTTP links. - The priority of the ProductDataEnricher plugin had to be set to normal, to allow hooks to be run before and after enrichment. - The deploy.sh has been cleaned-up and enriched with the deploy URL replacement originaly done in netlify.toml. Some alternate URLs has been changed or removed due to an enforcement of the rules regarding permalinks and alternate_urls (no more dots). Closes #2709, #3409.
|
Will be fixed by #2859 (I moved the |
marcwrobel
added a commit
that referenced
this issue
Aug 19, 2023
Compared to the use of the validate.py script / validate.yaml workflow, this has the advantage of ensuring the validation is always performed. It also gives access to enriched data, which is useful for validated generated content, such as links. In addition to checks already implemented in the previous 'validate.py' script, this script: - Check that release dates are not too far in the future to avoid mistakes such as #3281 (max 30 days allowed). - Check all links are valid (even those in the products description). This check takes time and is not performed by default, but it can be triggered by setting the MUST_CHECK_URLS environment variable to true. To ensure links are regularly verified a new GitHub workflow, check-links.yml, has also been added. It runs every sunday at midnight. Note that: - Some links had to be excluded from the link validation because, despite being valid, they are sometime or systematically returning an error. - A dependency to open-uri (https://github.com/ruby/open-uri) has been added to simplify the validation of HTTP links. - The priority of the ProductDataEnricher plugin had to be set to normal, to allow hooks to be run before and after enrichment. - The deploy.sh has been cleaned-up and enriched with the deploy URL replacement originaly done in netlify.toml. Some alternate URLs has been changed or removed due to an enforcement of the rules regarding permalinks and alternate_urls (no more dots). Closes #1206, #2709, #3409.
marcwrobel
added a commit
that referenced
this issue
Aug 19, 2023
Compared to the use of the validate.py script / validate.yaml workflow, this has the advantage of ensuring the validation is always performed. It also gives access to enriched data, which is useful for validated generated content, such as links. In addition to checks already implemented in the previous 'validate.py' script, this script: - Check that release dates are not too far in the future to avoid mistakes such as #3281 (max 30 days allowed). - Check all links are valid (even those in the products description). This check takes time and is not performed by default, but it can be triggered by setting the MUST_CHECK_URLS environment variable to true. To ensure links are regularly verified a new GitHub workflow, check-links.yml, has also been added. It runs every sunday at midnight. Note that: - Some links had to be excluded from the link validation because, despite being valid, they are sometime or systematically returning an error. - A dependency to open-uri (https://github.com/ruby/open-uri) has been added to simplify the validation of HTTP links. - The priority of the ProductDataEnricher plugin had to be set to normal, to allow hooks to be run before and after enrichment. - The deploy.sh has been cleaned-up and enriched with the deploy URL replacement originaly done in netlify.toml. Some alternate URLs has been changed or removed due to an enforcement of the rules regarding permalinks and alternate_urls (no more dots). Closes #1206, #2709, #3409.
|
The errors were visible in Netlify Post-processing logs, such as https://app.netlify.com/sites/endoflife-date/deploys/64e0a47ca0fe2f0007129028: In recent version (post #2859 merge), such as https://app.netlify.com/sites/endoflife-date/deploys/64e0a4148c837b000894a329, those errors cannot be seen anymore: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In logs we got lots of
Incorrect TOML configuration format: Escape sequence \: is reservedwhich is caused by
endoflife.date/netlify.toml
Line 10 in 0d4399f
The text was updated successfully, but these errors were encountered: