Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Page] CSP related problem #3551

Closed
adriens opened this issue Sep 15, 2023 · 8 comments · Fixed by #3606
Closed

[API Page] CSP related problem #3551

adriens opened this issue Sep 15, 2023 · 8 comments · Fixed by #3606
Labels
bug Something isn't working

Comments

@adriens
Copy link
Contributor

adriens commented Sep 15, 2023

Hi guys, the API webpage seems a bit buggy :

https://endoflife.date/docs/api
image

Do you see the same behavior ?

@adriens adriens added the enhancement New feature or request label Sep 15, 2023
@BiNZGi
Copy link
Member

BiNZGi commented Sep 15, 2023

I can confirm, I have the same with Chrome 116.0.5845.179. It seems related to CSP:
Screenshot from 2023-09-15 08-36-18

@usta
Copy link
Member

usta commented Sep 15, 2023 via email

@marcwrobel
Copy link
Member

Some of those glitches looks similar to #1762, which was an issue with some older LTS versions of Firefox.

@adriens
Copy link
Contributor Author

adriens commented Sep 18, 2023

i can confirm it on firefox focus and firefox nightly on mobile versions ( android )

On Fri, Sep 15, 2023, 09:38 BiNZGi @.> wrote: I can confirm, I have the same with Chrome 116.0.5845.179. It seems related to CSP: [image: Screenshot from 2023-09-15 08-36-18] https://user-images.githubusercontent.com/13657422/268196865-ecf7258f-cd8b-4f7e-8cbb-e1110e88087a.png — Reply to this email directly, view it on GitHub <#3551 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA3R4W5H37TNKUQS52SRLDX2PZXRANCNFSM6AAAAAA4ZGKM74 . You are receiving this because you are subscribed to this thread.Message ID: @.>

On Chrome/Windows too

@usta usta changed the title 🐛 Website > Buggy API page [API Page] CSP related problem Sep 19, 2023
@usta usta added bug Something isn't working and removed enhancement New feature or request labels Sep 19, 2023
@usta
Copy link
Member

usta commented Sep 19, 2023

@marcwrobel @BiNZGi can we implement classic image icons instead of svg ? Not sure if we are generating or a library generating this page. Also wont we use swagger for new api ? ( if so this is a temp, problem )

@marcwrobel
Copy link
Member

Nope, that's a Web Component, we cannot change anything. Maybe updating the CSP could fix the issue, at least for most recent browsers.

Yes, Swagger will be used for the new API and we won't have this problem anymore. But let's at least try to fix the CSP issue, that's not a big change.

@adriens
Copy link
Contributor Author

adriens commented Sep 19, 2023

Nope, that's a Web Component, we cannot change anything. Maybe updating the CSP could fix the issue, at least for most recent browsers.

That would very acceptable to ask people to stay up-to-date wth their browser 👍

Yes, Swagger will be used for the new API and we won't have this problem anymore.

🤩

But let's at least try to fix the CSP issue, that's not a big change.

🤞 Or 🙏 for an upgrade that my fix the issue 😸

marcwrobel added a commit that referenced this issue Sep 23, 2023
marcwrobel added a commit that referenced this issue Sep 23, 2023
marcwrobel added a commit that referenced this issue Sep 23, 2023
@adriens
Copy link
Contributor Author

adriens commented Sep 24, 2023

👌
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants