Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Product] Add Apache Maven build tool #1914

Merged
merged 1 commit into from Nov 30, 2022
Merged

[New Product] Add Apache Maven build tool #1914

merged 1 commit into from Nov 30, 2022

Conversation

adriens
Copy link
Contributor

@adriens adriens commented Nov 26, 2022 •
edited

❔ About

Apache Maven is a very used and well known buld tool for java.

🔖 Related resources

I have used Maven Releases History as a base data for the pull request.

📊 Maven usage stats

From this tweet :

image

image

@adriens
Copy link
Contributor Author

adriens commented Nov 26, 2022 •
edited

I don't understand what's wrong with the file 🤔 ...any help is welcome 🙏

@captn3m0
Copy link
Member

It's missing a layout: product

adriens
adriens commented Nov 26, 2022
View reviewed changes
Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf #1914 (comment)

@adriens
Copy link
Contributor Author

adriens commented Nov 26, 2022 •
edited

Guess the eol are not good, right ?... but what to put I have none @captn3m0 🙏 ❔

image

captn3m0
captn3m0 reviewed Nov 26, 2022
View reviewed changes
products/apache-maven.md Outdated Show resolved Hide resolved
captn3m0
captn3m0 reviewed Nov 26, 2022
View reviewed changes
products/apache-maven.md Outdated Show resolved Hide resolved
captn3m0
captn3m0 reviewed Nov 26, 2022
View reviewed changes
products/apache-maven.md Outdated Show resolved Hide resolved
captn3m0
captn3m0 reviewed Nov 26, 2022
View reviewed changes
products/apache-maven.md Outdated Show resolved Hide resolved
captn3m0
captn3m0 reviewed Nov 26, 2022
View reviewed changes
products/apache-maven.md Outdated Show resolved Hide resolved
@captn3m0
Copy link
Member

Left a few comments.

adriens
adriens commented Nov 26, 2022
View reviewed changes
Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully things will look better now @captn3m0 🤞 (and thank you for your reveiw and tips 👍 )

marcwrobel
marcwrobel reviewed Nov 26, 2022
View reviewed changes
products/apache-maven.md Outdated
releases:
- releaseCycle: "3.8"
eol: false
support: 2023-11-24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any end-of-support dates / EOL dates on https://maven.apache.org/docs/history.html. Could you add the link(s) containing that information in the product description ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only I got are the one for Maven 2 :
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and Maven 1 :
image

products/apache-maven.md Outdated Show resolved Hide resolved
captn3m0
captn3m0 reviewed Nov 26, 2022
View reviewed changes
products/apache-maven.md Outdated Show resolved Hide resolved
captn3m0
captn3m0 reviewed Nov 26, 2022
View reviewed changes
products/apache-maven.md Outdated Show resolved Hide resolved
adriens
adriens commented Nov 26, 2022
View reviewed changes
Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, not sure what to put for 3.x EoLs...

@marcwrobel
Copy link
Member

@adriens :

So it would be safer to assume only 3.8.x is maintained with no support / EOL dates:

-   releaseCycle: "3.8"
    eol: false
    support: true
    ...

And other versions are EOL, for instance:

-   releaseCycle: "3.6"
    eol: 2021-04-04 # 3.8 releaseDate
    support: 2021-04-04 # 3.8 releaseDate
    latest: "3.6.3"
    latestReleaseDate: 2019-11-25
    releaseDate: 2018-10-24

For anyone looking at this example, yes there was no official Apache Maven releases between 3.6.3 (2019-11-25) and 3.8.1 (2021-04-04) ;).

@captn3m0 any thought about this ?

@marcwrobel
Copy link
Member

It's missing a layout: product

@captn3m0, the product layout is the default layout according to _config.yml. And its nearly never explicitly mentioned. Why putting it in this case ?

@usta usta changed the title 🪶 Add Apache Maven build tool [New Product] Add Apache Maven build tool Nov 26, 2022
@usta usta added the new-product This PR adds a new product to the website. label Nov 26, 2022
@usta
Copy link
Member

usta commented Nov 26, 2022

I have fixed changelogtemplate now links should work correct

@captn3m0
Copy link
Member

the product layout is the default layout according to _config.yml

Let me check and file a PR

@captn3m0
Copy link
Member

I switched from tracking the maven git repo to tracking the maven maven repo 😄 instead.

The Apache release process is 3 step:

  1. Create a tag
  2. Get a vote
  3. Publish after vote passes.

We noted this when our tomcat automation (tracking the git repo) pre-published released, because the vote hadn't passed on them. Switching to the maven repo also gives us the 2.x tags as a benefit.

adriens
adriens commented Nov 26, 2022
View reviewed changes
Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed EoLs cf #1914 (comment)

@adriens
Copy link
Contributor Author

adriens commented Nov 26, 2022

I switched from tracking the maven git repo to tracking the maven maven repo smile instead.

The Apache release process is 3 step:

1. Create a tag

2. Get a vote

3. Publish after vote passes.

We noted this when our tomcat automation (tracking the git repo) pre-published released, because the vote hadn't passed on them. Switching to the maven repo also gives us the 2.x tags as a benefit.

Super cool job 💪 about Apache release process 💯

@adriens
Copy link
Contributor Author

adriens commented Nov 26, 2022

EoLs have been patched, including "guessed EoLs"

@marcwrobel
Copy link
Member

@adriens:

  • guessed EOL dates should be the next cycle release date,
  • cycle 3.1 is missing,
  • some release date are wrong,
  • cycle name should be 1.0, not 1.1 for the first cycle.

Here is what I mean :

diff --git a/products/apache-maven.md b/products/apache-maven.md
index 162d6f2..3a2c44d 100644
--- a/products/apache-maven.md
+++ b/products/apache-maven.md
@@ -33,29 +33,36 @@ releases:
     releaseDate: 2018-10-24
 
 -   releaseCycle: "3.5"
-    eol: 2021-04-04
-    support: 2021-04-04
+    eol: 2018-10-24
+    support: 2018-10-24
     latest: "3.5.4"
     latestReleaseDate: 2018-06-21
     releaseDate: 2017-04-07

 -   releaseCycle: "3.3"
-    eol: 2021-04-04
-    support: 2021-04-04
+    eol: 2017-04-07
+    support: 2017-04-07
     latest: "3.3.9"
     latestReleaseDate: 2015-11-14
     releaseDate: 2015-03-18
 
 -   releaseCycle: "3.2"
-    eol: 2021-04-04
-    support: 2021-04-04
+    eol: 2015-03-18
+    support: 2015-03-18
     latest: "3.2.5"
     latestReleaseDate: 2014-12-20
     releaseDate: 2014-02-21

+-   releaseCycle: "3.1"
+    eol: 2014-02-21
+    support: 2014-02-21
+    latest: "3.2.5"
+    latestReleaseDate: 2013-10-04
+    releaseDate: 2013-07-15
+
 -   releaseCycle: "3.0"
-    eol: 2021-04-04
-    support: 2021-04-04
+    eol: 2013-07-15
+    support: 2013-07-15
     latest: "3.0.5"
     latestReleaseDate: 2013-02-23
     releaseDate: 2010-10-08
@@ -65,7 +72,7 @@ releases:
     support: 2014-02-18
     latest: "2.2.1"
     latestReleaseDate: 2009-11-08
-    releaseDate: 2005-10-20
+    releaseDate: 2009-06-30
     
 -   releaseCycle: "2.1"
     eol: 2014-02-18
@@ -79,9 +86,9 @@ releases:
     support: 2014-02-18
     latest: "2.0.11"
     latestReleaseDate: 2010-02-26
-    releaseDate: 2005-10-20    
+    releaseDate: 2005-10-20

--   releaseCycle: "1.1"
+-   releaseCycle: "1.0"
     eol: 2014-02-18
     support: 2014-02-18
     latest: "1.1"

Anyway, I wonder if we should simplify things and only keep major versions (1, 2, 3), like it was done for https://endoflife.date/gradle. @captn3m0 what do you think ?

adriens
adriens commented Nov 27, 2022
View reviewed changes
Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit better thanks to #1914 (comment) @marcwrobel review

@adriens
Copy link
Contributor Author

adriens commented Nov 28, 2022

Is it better now @marcwrobel ?

@marcwrobel
Copy link
Member

Support date for release cycle 3.3 is still wrong. Apart from that everything else looks OK.

We still have to decide if we should simplify things and only keep major versions (1, 2, 3), like it was done for https://endoflife.date/gradle (in this PR or in another PR). Waiting for feedback from @captn3m0.

adriens
adriens commented Nov 28, 2022
View reviewed changes
Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we go for #1914 (comment) @marcwrobel

@adriens
Copy link
Contributor Author

adriens commented Nov 28, 2022

It should only remain to [...]decide if we should simplify things and only keep major versions (1, 2, 3),

@marcwrobel
Copy link
Member

Just rebased the branch and removed the unnecessary layout override.

@usta
Copy link
Member

usta commented Nov 28, 2022 •
edited

I just have a question ? do we or anyone else need version history for minor releases ?
I mean couldnt we just combine all 2.x version [ and also 3.x versions] instead of writing them seperately?
i mean isnt each of them kills previous point release ?
or maybe we need something like this and keep this history datas via something like this #1940

@adriens
Copy link
Contributor Author

adriens commented Nov 29, 2022

I just have a question ? do we or anyone else need version history for minor releases ? I mean couldnt we just combine all 2.x version [ and also 3.x versions] instead of writing them seperately? i mean isnt each of them kills previous point release ? or maybe we need something like this and keep this history datas via something like this #1940

No special opinion at this poit (I'm a newbee here 😸 )

@usta
Copy link
Member

usta commented Nov 29, 2022 •
edited

No special opinion at this poit (I'm a newbee here 😸 )

you are not the problem here , I also want to keep version history and it might be helpful for future but we need
a new syntax to overcome this problem which i mentioned at #1940

@marcwrobel
Copy link
Member

@usta, that was what I meant in #1914 (comment). I also think it makes more sense to only keep track of the major versions, like we did for https://endoflife.date/gradle.

I squashed the older commits and added a new one that change release cycles from x.y to x. @adriens, @usta, let me know if it's OK for you.

@adriens
Copy link
Contributor Author

adriens commented Nov 29, 2022

Sure @marcwrobel 🚀 Go ahead 👏 💪

@captn3m0
Copy link
Member

Didn't get to see this earlier, but +1 to using major versions as release cycles here. We should only split those up if multiple are supported at any given time.

captn3m0
captn3m0 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcwrobel
marcwrobel approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's start with that.

@adriens @marcwrobel
[New Product] Apache Maven (#1914)
71def75 
Using major versions as release cycles: each minor version deprecates the previous one.
@marcwrobel marcwrobel merged commit a33b803 into endoflife-date:master Nov 30, 2022
@adriens adriens deleted the patch-8 branch November 30, 2022 11:54
@adriens
Copy link
Contributor Author

adriens commented Nov 30, 2022

🪄
image

adriens added a commit to opt-nc/vhs that referenced this pull request Nov 30, 2022
@adriens
Add maven EoL
da19c20 
cf : 

- endoflife-date/endoflife.date#1914 (comment)
@adriens
Copy link
Contributor Author

adriens commented Nov 30, 2022

Tweet

image

YT Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captn3m0 captn3m0 captn3m0 approved these changes

@marcwrobel marcwrobel marcwrobel approved these changes

Assignees
No one assigned
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adriens @captn3m0 @marcwrobel @usta