-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extended support column #2157
Conversation
@captn3m0, @Evernow, is this what you had in mind: https://deploy-preview-2157--endoflife-date.netlify.app/rhel ? |
I think when this column is used it should be clearly stated in the product description that this "extended support" is not free (and the conditions to obtain it). And maybe the text in the table should be a little bit different (italic, lighter font size...) ? |
The preview looks good, but not so sure about the API: https://deploy-preview-2157--endoflife-date.netlify.app/api/rhel.json I wanted to have column level customization, so we could do: columns:
- release: {template: releaseLabel}
- releaseDate {type: date}
- support: {type: BooleanOrDate}
- eol: {type: BooleanOrDate}
- extended: {type: BooleanOrDate}
- latestVersion: {template: changelogTemplate} This would have helped with moving around our columns. But looking at the simplicity of this PR, I think this is a much simpler way. We can add more customization when we move our logic from liquid to Ruby separately. |
This will need changes to the calendar as well. |
You are right, completely missed it ! I added a todo list in the PR description. |
@captn3m0, sorry, I do not understand. I think I am confused by the |
e49cb5a
to
6587cc7
Compare
6587cc7
to
65aa683
Compare
@captn3m0, on more thing I just noticed : should latest date be disabled when there is still extended support (example : cycle 6 on https://deploy-preview-2157--endoflife-date.netlify.app/rhel) ? I would say no but I prefer to ask first. |
Calendar support added: labels can be improved, it will be done in #2171. Extended support dates are automatically showed in the API, nothing to do. |
The column idea came from #404, just noting it down here, since it's relevant. Don't think we need to go down that path for now. We just have to be sure of the semantics. |
f46acb8
to
65fb55d
Compare
65fb55d
to
df137b9
Compare
Think this PR is ready for a proper review. We can list products that needs to be modified in a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we make a list of other pages where this might be useful?
df137b9
to
0bbcdd1
Compare
Conflicts resolved. |
Just opened #2246 for that: I prefer not to block this PR for that. I let you merge if you think it's ok. |
This PR is used to test the addition of a new "Extended support" column (as seen in https://github.com/endoflife-date/endoflife.date/pull/1254/files#r884229115).
TODO :