Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended support column #2157

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Add extended support column #2157

merged 3 commits into from
Jan 4, 2023

Conversation

marcwrobel
Copy link
Member

@marcwrobel marcwrobel commented Dec 27, 2022

This PR is used to test the addition of a new "Extended support" column (as seen in https://github.com/endoflife-date/endoflife.date/pull/1254/files#r884229115).

TODO :

  • Initial POC
  • Support extended support in Calendar
  • Document the new fields
  • Decide if EOLed cycles that are in the extended support phase must be disabled or not.

@marcwrobel
Copy link
Member Author

@captn3m0, @Evernow, is this what you had in mind: https://deploy-preview-2157--endoflife-date.netlify.app/rhel ?

@marcwrobel
Copy link
Member Author

I think when this column is used it should be clearly stated in the product description that this "extended support" is not free (and the conditions to obtain it).

And maybe the text in the table should be a little bit different (italic, lighter font size...) ?

@captn3m0
Copy link
Member

The preview looks good, but not so sure about the API: https://deploy-preview-2157--endoflife-date.netlify.app/api/rhel.json

I wanted to have column level customization, so we could do:

columns:
- release: {template: releaseLabel}
- releaseDate {type: date}
- support: {type: BooleanOrDate}
- eol: {type: BooleanOrDate}
- extended: {type: BooleanOrDate}
- latestVersion: {template: changelogTemplate}

This would have helped with moving around our columns.

But looking at the simplicity of this PR, I think this is a much simpler way. We can add more customization when we move our logic from liquid to Ruby separately.

@captn3m0 captn3m0 mentioned this pull request Dec 28, 2022
@captn3m0
Copy link
Member

This will need changes to the calendar as well.

@marcwrobel
Copy link
Member Author

marcwrobel commented Dec 28, 2022

This will need changes to the calendar as well.

You are right, completely missed it ! I added a todo list in the PR description.

@marcwrobel
Copy link
Member Author

marcwrobel commented Dec 29, 2022

I wanted to have column level customization, so we could do:
...
This would have helped with moving around our columns.

@captn3m0, sorry, I do not understand. I think I am confused by the  BooleanOrDate mentions. This new columns attribute is at the product or releases level ?

@marcwrobel
Copy link
Member Author

marcwrobel commented Dec 29, 2022

@captn3m0, on more thing I just noticed : should latest date be disabled when there is still extended support (example : cycle 6 on https://deploy-preview-2157--endoflife-date.netlify.app/rhel) ?

I would say no but I prefer to ask first.

@marcwrobel
Copy link
Member Author

marcwrobel commented Dec 29, 2022

Calendar support added: labels can be improved, it will be done in #2171.

Extended support dates are automatically showed in the API, nothing to do.

@captn3m0
Copy link
Member

The column idea came from #404, just noting it down here, since it's relevant. Don't think we need to go down that path for now. We just have to be sure of the semantics.

marcwrobel added a commit that referenced this pull request Dec 30, 2022
marcwrobel added a commit that referenced this pull request Dec 31, 2022
@marcwrobel marcwrobel marked this pull request as ready for review December 31, 2022 00:07
@marcwrobel marcwrobel changed the title Add extended support column (wip) Add extended support column Dec 31, 2022
@marcwrobel
Copy link
Member Author

Think this PR is ready for a proper review.

We can list products that needs to be modified in a separate issue.

@marcwrobel marcwrobel added the enhancement New feature or request label Dec 31, 2022
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we make a list of other pages where this might be useful?

@marcwrobel
Copy link
Member Author

Conflicts resolved.

@marcwrobel
Copy link
Member Author

LGTM. Can we make a list of other pages where this might be useful?

Just opened #2246 for that: I prefer not to block this PR for that. I let you merge if you think it's ok.

@marcwrobel marcwrobel merged commit 428cb84 into master Jan 4, 2023
@marcwrobel marcwrobel deleted the extended-support-column branch January 4, 2023 15:40
marcwrobel added a commit that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants