Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pages description #2577

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix pages description #2577

merged 1 commit into from
Mar 1, 2023

Conversation

marcwrobel
Copy link
Member

Product pages description was broken since the introduction of the 'product' layout. Moreover, jekyll-seo-tag already handles description and og:description meta tags, so there is no need to override them using the head_custom template.

All pages descriptions were also simplified in the process.

@marcwrobel marcwrobel added the bug Something isn't working label Feb 24, 2023
Product pages description was broken since the introduction of the 'product' layout. Moreover, jekyll-seo-tag already handles description and og:description meta tags, so there is no need to override them using the head_custom template.

All pages descriptions were also simplified in the process.
@marcwrobel marcwrobel changed the title Fix pages description (#28) Fix pages description Feb 24, 2023
@marcwrobel
Copy link
Member Author

Relates to #28.

Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@captn3m0 captn3m0 merged commit 252445b into master Mar 1, 2023
@captn3m0 captn3m0 deleted the fix-page-descriptions branch March 1, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants