Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag products #2756

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Tag products #2756

merged 2 commits into from
Jun 14, 2023

Conversation

marcwrobel
Copy link
Member

@marcwrobel marcwrobel commented Mar 29, 2023

Define rules for tags in CONTRIBUTING.md, and add tags (aka labels) to products (relates to #2225).

This commit focus on a limited set of tags, meaning:

  • tags to set a product family such as linux-distribution, web-browser, mobile-phone or web-server,
  • tags to set a product vendor such as adobe, amazon or apache,
  • tags to set a runtime dependency such as java-runtime, javascript-runtime or php-runtime.

How tags are displayed on the website will be handled later.

@adriens
Copy link
Contributor

adriens commented Mar 29, 2023

Could we get a tag for the tea.xyz package ?

For example for sqllite :

👇

@captn3m0
Copy link
Member

captn3m0 commented Mar 30, 2023

We already support identifiers for other package ecosystems via the identifiers key, which links to various PURLs. There isn't a tea PURL type yet, but one could be create fairly easily, and we can add the corresponding PURLs in the identifiers key post that.

So, it could be as simple as:

identifiers:
- purl: pkg:tea/python.org

@marcwrobel
Copy link
Member Author

Rebased against master to include #2759.

@marcwrobel
Copy link
Member Author

Rebased against master, conflicts resolved.

@marcwrobel
Copy link
Member Author

Rebased with master, conflicts resolved.

@marcwrobel marcwrobel force-pushed the 2225-tags branch 2 times, most recently from 454b7f6 to c37fd14 Compare May 12, 2023 19:13
@marcwrobel
Copy link
Member Author

Rebased with master, conflicts resolved. @captn3m0 could you have a look at this PR asap. It's a little bit annoying to maintain it.

@marcwrobel marcwrobel force-pushed the 2225-tags branch 3 times, most recently from 32852c6 to 6b8cae4 Compare May 23, 2023 19:50
@marcwrobel marcwrobel force-pushed the 2225-tags branch 2 times, most recently from 6d9a994 to 9a97a86 Compare June 11, 2023 18:36
@marcwrobel
Copy link
Member Author

@captn3m0 could you have a look at this PR this week ? It's a simple one, but it is a little bit annoying to maintain it.

Define rules for tags in CONTRIBUTING.md, and add tags (aka labels) to products.

This commit focus on a limited set of tags, meaning:

- tags to set a product family such as linux-distribution, web-browser, mobile-phone or web-server,
- tags to set a product vendor such as adobe, amazon or apache,
- tags to set a runtime dependency such as java-runtime, javascript-runtime or php-runtime.
@marcwrobel
Copy link
Member Author

Conflicts resolved again. @captn3m0 I am merging this PR as it is annoying to maintain. I did a full review and its LGTM, but feel free to revert or amend if needs be.

This PR also fixes an issue introduced by the merge of the IBM AIX PR (validation workflow was did not work). #2859 should solve this.

@marcwrobel marcwrobel merged commit 8d8dcb8 into master Jun 14, 2023
7 checks passed
@marcwrobel marcwrobel deleted the 2225-tags branch June 14, 2023 21:04
@marcwrobel marcwrobel linked an issue Jun 14, 2023 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tags in endoflife.date
3 participants