Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new product] Add Zentyal #5182

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nojszewski
Copy link

@nojszewski nojszewski commented May 25, 2024

Add Zentyal to available products list.
https://zentyal.com/

Copy link

welcome bot commented May 25, 2024

Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals.

@nojszewski nojszewski changed the title [new-product] Add Zentyal to products [new product] Add Zentyal May 26, 2024
@nojszewski
Copy link
Author

@marcchabrol can u or someone look at it?

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more suggestions:

  1. Please change eol to eoes and add eoasColumnLabel: Commercial Support so distinction becomes clear
  2. Change eol to the EOL dates of the Development Edition accordingly. This should follow eol(X) = releaseDate(X+1) from what I understand.
  3. A customColumn for the corresponding ubuntuVersion would be nice. You can check vmware-photon.md for a simple usage.
  4. Should we add a Active Support column? I'm guessing only the latest major release gets new features (the next will be 8.1?). This will be helpful information as well.

Q: Is there a changelog published for the Commercial Edition? Maybe just version numbers? Would be nice to have a link so users can check if they are lagging behind.

products/zentyal.md Outdated Show resolved Hide resolved
products/zentyal.md Outdated Show resolved Hide resolved
products/zentyal.md Outdated Show resolved Hide resolved
products/zentyal.md Outdated Show resolved Hide resolved
products/zentyal.md Show resolved Hide resolved
@captn3m0 captn3m0 self-assigned this May 29, 2024
@captn3m0 captn3m0 added the new-product This PR adds a new product to the website. label May 29, 2024
Co-authored-by: Nemo <me@captnemo.in>
@captn3m0
Copy link
Member

In addition to the above 3, there should be a latest key for every release as latestColumn is visible. Our build is erroring out with the following:

1:54:32 AM:  Product Validator: Invalid latest '' for zentyal.md#releases#7.0, expecting a value of type String, got NilClass.
1:54:32 AM:  Product Validator: Invalid latest '' for zentyal.md#releases#6.0, expecting a value of type String, got NilClass.
1:54:32 AM:  Product Validator: Invalid latest '' for zentyal.md#releases#5.0, expecting a value of type String, got NilClass.
1:54:32 AM:  Product Validator: Invalid latest '' for zentyal.md#releases#4.0, expecting a value of type String, got NilClass.
1:54:32 AM:  Product Validator: Invalid latest '' for zentyal.md#releases#3.2, expecting a value of type String, got NilClass.
1:54:32 AM:  Product Validator: Invalid latest '' for zentyal.md#releases#3.0, expecting a value of type String, got NilClass.
1:54:32 AM:  Product Validator: Invalid latest '' for zentyal.md#releases#2.2, expecting a value of type String, got NilClass.

Add latest versions to all releases
Add ubuntuVersion custom column
@nojszewski
Copy link
Author

Q: Is there a changelog published for the Commercial Edition? Maybe just version numbers? Would be nice to have a link so users can check if they are lagging behind.

I found only this => https://wiki.zentyal.org/wiki/Official_Zentyal_doc - it's a docs, but there are all versions listed. I think, commercial and development editions version numbers are the same.

I also added custom column for corresponding Ubuntu LTS version.

@nojszewski nojszewski requested a review from captn3m0 May 31, 2024 21:24
@nojszewski
Copy link
Author

And now what?

@BiNZGi
Copy link
Member

BiNZGi commented Jun 10, 2024

The points 1, 2, 4 and Q from #5182 (review) are still open/unanswered from my point of view. After that @captn3m0 can review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants