Fix product identifiers #5301
Merged
Fix product identifiers #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captn3m0
added
the
product-fixes
This was referenced Jun 17, 2024
marcwrobel
approved these changes
Jul 6, 2024
Since the filename is used by release-data, and possibly
other products, this ensures that:
1. the filename is always present in the permalink or alternate_urls
2. You can always assume that endoflife.date/api/{filename}.json will
return a JSON response.
This results in no breaking changes to the API
(with a minor exception for /raspberypi being dropped).
This might impact users who use the git repo as a dataset.
Ref: endoflife-date/release-data#352
marcwrobel
force-pushed
the
identifier-fixes
branch
from
b48ba72
to
1be554a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the filename is used by release-data, and possibly other products, this ensures that:
This results in no breaking changes to the API
(with a minor exception for /raspberypi being dropped).
This might impact users who use the git repo as a dataset.
Ref: endoflife-date/release-data#352