-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot import @agoric/harden under SES-0.7.4 without noTameRegExp #237
Comments
Oh and of course the problem goes away if I add |
erights
added a commit
that referenced
this issue
Mar 23, 2020
erights
added a commit
that referenced
this issue
Mar 23, 2020
Bad RegExp taming revealed by #237 Exclude similar but new test failures
Fixed in #243 |
warner
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Mar 24, 2020
refs #739 Note, for unit tests, `install-ses.js` disables some SES security features, one because of a bug in SES (endojs/endo#237), and another because `rollup` uses Math.random for reasons that are not clear. We'll need to fix or find workarounds for both: eventually this test should work without those two patches.
warner
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Mar 25, 2020
refs #739 Note, for unit tests, `install-ses.js` disables some SES security features, one because of a bug in SES (endojs/endo#237), and another because `rollup` uses Math.random for reasons that are not clear. We'll need to fix or find workarounds for both: eventually this test should work without those two patches.
warner
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Mar 26, 2020
refs #739 Note, for unit tests, `install-ses.js` disables some SES security features, one because of a bug in SES (endojs/endo#237), and another because `rollup` uses Math.random for reasons that are not clear. We'll need to fix or find workarounds for both: eventually this test should work without those two patches.
warner
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Mar 27, 2020
refs #739 Note, for unit tests, `install-ses.js` disables some SES security features, one because of a bug in SES (endojs/endo#237), and another because `rollup` uses Math.random for reasons that are not clear. We'll need to fix or find workarounds for both: eventually this test should work without those two patches.
warner
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Mar 27, 2020
refs #739 Note, for unit tests, `install-ses.js` disables some SES security features, one because of a bug in SES (endojs/endo#237), and another because `rollup` uses Math.random for reasons that are not clear. We'll need to fix or find workarounds for both: eventually this test should work without those two patches.
warner
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Mar 27, 2020
refs #739 Note, for unit tests, `install-ses.js` disables some SES security features, one because of a bug in SES (endojs/endo#237), and another because `rollup` uses Math.random for reasons that are not clear. We'll need to fix or find workarounds for both: eventually this test should work without those two patches.
warner
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Apr 1, 2020
refs #739 Note, for unit tests, `install-ses.js` disables some SES security features, one because of a bug in SES (endojs/endo#237), and another because `rollup` uses Math.random for reasons that are not clear. We'll need to fix or find workarounds for both: eventually this test should work without those two patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following CJS program:
when run in an initially-empty directory where I've done
yarn add esm ses@0.7.4 @agoric/harden@0.0.4
, yields the following error:The line in question (
harden.cjs.js
line 280) is trying totoString
an undeniable:If I change the
${undeniable}
to${name}
, it reveals the unexpected undeniable:I'm guessing that our fix for #230 was incomplete somehow, and the check that
harden
does is confused. There are two problems here: the first triggering this Error, and the second is that the undeniable in question throws a second error when the first one tries to calltoString
onRegExp.prototype
.The text was updated successfully, but these errors were encountered: