Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockdown() should bail if it cannot get a direct eval #343

Closed
warner opened this issue Jun 18, 2020 · 1 comment · Fixed by #1002
Closed

lockdown() should bail if it cannot get a direct eval #343

warner opened this issue Jun 18, 2020 · 1 comment · Fixed by #1002
Assignees
Labels
confinement Pertaining to confinement of guest programs. enhancement New feature or request

Comments

@warner
Copy link
Contributor

warner commented Jun 18, 2020

Agoric/agoric-sdk#1182 fixed a problem in the metering transform which broke the direct eval that SES-shim needs to build the proxy-scoped evaluator (turning it into an indirect eval). The symptom was subtle: added endowments went missing, but evaluation worked fine otherwise.

Should we add code to lockdown() to assert that it has access to a functional direct eval, and abort if it does not? The SES shim is, of course, entirely dependent upon the environment that loads it, but if a vetted shim were to unintentionally break direct eval, it might be better to halt than to produce a subtly-broken SES environment.

Originally posted by @warner in Agoric/agoric-sdk#1182 (comment)

@erights
Copy link
Contributor

erights commented Jun 19, 2020 via email

@warner warner changed the title should lockdown() bail if it cannot get a direct eval? lockdown() should bail if it cannot get a direct eval Jun 19, 2020
@kriskowal kriskowal added the enhancement New feature or request label Aug 13, 2020
@erights erights self-assigned this Feb 26, 2021
@erights erights added the confinement Pertaining to confinement of guest programs. label Jun 26, 2021
@Tartuffo Tartuffo assigned kriskowal and unassigned erights Jan 21, 2022
kriskowal added a commit that referenced this issue Jan 22, 2022
kriskowal added a commit that referenced this issue Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confinement Pertaining to confinement of guest programs. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants