fix(ses): fix broken types for CJS consumers #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
force-pushed
the
boneskull/fix-cjs-types
branch
from
3f68ef6
to
deabefa
Compare
boneskull
added
bug
kriskowal
requested changes
Apr 30, 2024
boneskull
force-pushed
the
boneskull/fix-cjs-types
branch
from
965125c
to
7e672ea
Compare
kriskowal
approved these changes
May 6, 2024
Due to changes in TS v5.5, CJS consumers cannot import types from a `type: module` package unless the declaration file has the `.d.cts` extension. This may or may not work the other way. See https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-beta/\#respecting-file-extensions-and-packagejson-in-other-module-modes for explanation.
Co-authored-by: Kris Kowal <kris@agoric.com>
kriskowal
force-pushed
the
boneskull/fix-cjs-types
branch
from
7e672ea
to
5f7e78e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in TS v5.5, CJS consumers cannot import types from a
type: modulepackage unless the declaration file has the.d.ctsextension. This may or may not work the other way.See the v5.5. beta announcement for further explanation.