Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ses): fix broken types for CJS consumers #2260

Merged
merged 2 commits into from
May 6, 2024
Merged

fix(ses): fix broken types for CJS consumers #2260

merged 2 commits into from
May 6, 2024

Commits on May 6, 2024

  1. fix(ses): fix broken types for CJS consumers 

    Due to changes in TS v5.5, CJS consumers cannot import types from a `type: module` package unless the declaration file has the `.d.cts` extension.  This may or may not work the other way.

See https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-beta/\#respecting-file-extensions-and-packagejson-in-other-module-modes for explanation.
    @boneskull @kriskowal
    boneskull authored and kriskowal committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a950b99 View commit details
    Browse the repository at this point in the history

  2. chore(ses): update comment 

    Co-authored-by: Kris Kowal <kris@agoric.com>
    @boneskull @kriskowal
    boneskull and kriskowal committed May 6, 2024
    Configuration menu
    Copy the full SHA
    5f7e78e View commit details
    Browse the repository at this point in the history