Kill obsolete repair-legacy-accessors

[erights]

What are the minimal implementations of JS that the SES-shim should support? I ask because I'd like to delete
https://github.com/Agoric/SES-shim/blob/master/packages/ses/src/repair-legacy-accessors.js
from the SES-shim implementation. A good test to see if it is needed is

(0, Object.prototype.__lookupGetter__)('x');

On all platforms of interest to us this throws. If there's a platform of interest where it does not, that would be a reason to keep it and reject or postpone this PR. Making this PR a WIP Draft so it doesn't get merged until we resolve this question.

Attn @danfinlay @kumavis please consider yourself reviewers. (For some reason I do not seem to be able to add you as reviewers.)

[kriskowal]

I imagine this would be a safe change, or at least one we could revert if we found cause.

I believe we will have more leeway to add @kumavis @danfinlay and others as reviewers when they are repository collaborators or organization members, and that might be around the corner when we move this to https://github.com/endojs

[erights]

I imagine this would be a safe change, or at least one we could revert if we found cause.

I believe we will have more leeway to add @kumavis @danfinlay and others as reviewers when they are repository collaborators or organization members, and that might be around the corner when we move this to https://github.com/endojs

I was able to add @danfinlay but not @kumavis .

Hi @danfinlay !

[erights]

This is now ready for review.

[kumavis]

ive never identified a need for it or fully understood what it was for
happy to see it removed and report if that causes an issue somehow

metamask build sys + lavamoat already dropped node 10, as it went EOL

not sure what targets this workaround is for, but unlikely we support them