feat(ag-trade): fetch, (un)marshal, lookup, sign... add to reserve #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great hello, world @dckc! I had to remove This took a whopping ~5 seconds.... aaand voila! 🪄
🚀 amazing way to break ground on (what i expect to be the) safest adult playground to ever grace the interwebs 😎 |
smart wallet offers such as add to reservePrerequisite: Then: |
dckc
changed the title
dckc
commented
Jan 10, 2024
Comment on lines
+7
to
+11
| import { | ||
| SigningStargateClient, | ||
| assertIsDeliverTxSuccess, | ||
| } from '@cosmjs/stargate'; | ||
| import { Tendermint34Client } from '@cosmjs/tendermint-rpc'; |
There was a problem hiding this comment.
This shouldn't have to be an --UNSAFE plugin -- the network stuff is all in a separate vat -- but I'm struggling to get protobuf stuff to run confined. See:
dckc
commented
Jan 10, 2024
| return Far('HdWallet', methods); | ||
| }; | ||
|
|
||
| export const make = async () => Far('HdWalletMaker', { fromMnemonic }); |
There was a problem hiding this comment.
computing signatures should be able to run in a separate caplet from the rest of the smartWallet code, but we can't marshal byte sequences:
dckc
commented
Jan 10, 2024
| const synthesizeRemotable = (slot, iface) => | ||
| Far(`${(iface ?? '').replace(/^Alleged: /, '')}#${slot}`, {}); | ||
|
|
||
| export const makeClientMarshaller = () => { |
There was a problem hiding this comment.
This should perhaps be imported from ui-kit, but the version there has an issue:
dckc
force-pushed
the
dc-ag-trade
branch
3 times, most recently
from
5e74e29
to
4533681
Compare
Goal: PetName interopWhile working on some prototypes Agoric dapps in an internal hackathon, we had
rest of details moved to README |
$ git -C ../finquick/ log10 packages/ag-trade/src/cosmosFetch.js 2023-12-27 01:35 1851101 chore(cosmosFetch): detect missing fetch function $ git -C ../finquick/ log10 packages/ag-trade/src/httpClient.js 2023-11-24 21:47 f8b9a5c feat: separate fetch worker from smartWallet worker
NOTE: using the exact versions from finquick worked, but just doing `yarn add X` for these packages resulted in RemoteTypeError(error:captp:Endo#20001)#1: Cannot assign to read only property 'constructor' of object '[object Object]' and I couldn't find any more stack info - buid(ag-trade): add @endo/far for caplets
- smartWallet: entries, keys in agoricNames from vstorage
- with @endo/far
dckc
changed the title
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1
After setting up lint/test devtools and such (#6), I'm migrating stuff from finquick and swaparoo.
A hello-world chain interaction works:
cc @tgrecojs @kriskowal