Agoric offer signer endo maker #64

dckc · 2023-11-19T04:12:30Z

SES_EVAL_REJECTED in protobufjs

tried testing...

fincaps$ endo make src/hdWallet.js -n w1
CapTP cli exception: (RemoteSyntaxError(error:captp:Endo#20001)#1)
RemoteSyntaxError(error:captp:Endo#20001)#1: Possible direct eval expression rejected at <unknown>:12. (SES_EVAL_REJECTED)

  at decodeErrorCommon (packages/marshal/src/marshal.js:281:28)
  at decodeErrorFromCapData (packages/marshal/src/marshal.js:297:14)
  at decodeFromCapData (packages/marshal/src/encodeToCapData.js:404:27)
  at fromCapData (packages/marshal/src/marshal.js:359:23)
  at CTP_RETURN (packages/captp/src/captp.js:697:24)
  at dispatch (packages/captp/src/captp.js:776:7)
  at packages/daemon/src/connection.js:34:7

worker log is not much help:

Endo worker started on pid 167205
Temporary logging of sent error (SyntaxError#1)
SyntaxError#1: Possible direct eval expression rejected at <unknown>:12. (SES_EVAL_REJECTED)

  at rejectSomeDirectEvalExpressions (packages/ses/src/transforms.js:222:9)
  at applyTransforms (packages/ses/src/transforms.js:252:14)
  at safeEvaluate (packages/ses/src/make-safe-evaluator.js:65:14)

so I used the b2zip.sh idiom:

#!/bin/sh
bundle=$1
zip=$2
jq -r .endoZipBase64 b.json| base64 -d > $2

And I found eval in @protobufjs/inquire-v1.1.0/index.js

and then jq -r .source @protobufjs/inquire-v1.1.0/index.js|less -N
to see... sure enough...

   12         var mod = eval("quire".replace(/^/,"re"))(moduleName); // eslint-disable-line no-eval

dckc · 2023-11-19T22:40:47Z

signing client can `sendTokens`

check balance before:

~/projects/gimix$ yarn docker:make balance-q
$ docker-compose exec agd make -C /workspace balance-q
agd query bank balances agoric1a3zu5aqw255q0tuxzy9aftvgheekw2wedz3xwq
balances:
- amount: "329930000"
  denom: ubld

send tokens using endo:

finquick/packages/fincaps$ make send-tokens
++ Send tokens
endo eval "E(client).sendTokens(\
  'agoric14pfrxg63jn6ha0cp6wxkm4nlvswtscrh2pymwm', \
  'agoric1a3zu5aqw255q0tuxzy9aftvgheekw2wedz3xwq', \
  [{ denom: 'ubld', amount: '12345' }], 'auto').then( \
  tx => tx.code === 0 ? tx.transactionHash : assert.fail(tx.rawLog))" client:validator-client
EABABE9AEF40D07E8185C3E608DE29F9CFECA0B653772FFFC01D299C5FA61EBA

balance after:

~/projects/gimix$ yarn docker:make balance-q
...
balances:
- amount: "329942345"
  denom: ubld

2023-11-19 16:39 4db7401 docs: send-tokens with endo (Makefile target)
2023-11-19 14:25 9e87d73 test: regen fixture
2023-11-19 14:25 ed07d38 test: replay fetch() utility
2023-11-19 14:25 6f3c7e4 feat: RpcClient using explicit access to the network
2023-11-19 09:45 a353b1a feat: smartWallet endo component
2023-11-19 08:39 0130695 feat: hdWallet endo plugin / module
2023-11-18 21:50 6ebc1e1 feat: offerSigner endo plug-in
2023-11-18 21:50 213e21f lock packages with cosmjs
2023-11-18 21:50 f0b8cd9 build(fincaps): cosmjs, @agoric/cosmic-proto

dckc · 2023-11-20T07:14:21Z

endo smartWallet plugin can query vstorage, execute offers

This endo plug-in has the essential features of a client in the Smart Wallet Dapp Architecture. It can

query the chain to look up things like brands and contract instances
sign and broadcast offers
- track offers until they complete

~/projects/finquick/packages/fincaps$ make reserve-add
++ look up IST in user1 marshal context
endo eval "E(kit.query).lookup('agoricNames', 'brand', 'IST')" -n u1-ist kit:user1-kit
Object [Alleged: IST brand] {}
++ Add to reserve
endo eval "E(reserve).addToReserve(kit.smartWallet, \
  { brand, value: 7_000_000n }, 'add2')" \
  reserve:reserve-tool kit:user1-kit brand:u1-ist
{
  status: {
    id: 'add2',
    invitationSpec: {
      callPipe: [Array],
      instancePath: [Array],
      source: 'agoricContract'
    },
    numWantsSatisfied: 1,
    payouts: { Collateral: [Object] },
    proposal: { give: [Object] },
    result: 'added Collateral to the Reserve'
  },
  tx: {
    height: 270595,
    transactionHash: '4789F93D1BC8262AE8DFB598923BF1267EFED05F287328EC78C888A6EB49EA5C'
  }
}

2023-11-20 01:04 568c38d docs: reserve-add demo using smartWallet.js

dckc · 2023-11-20T18:41:47Z

tab dump of some stuff I researched while working on this...
(see also contemporary diigo bookmarks)

Agoric offer signer endo maker by dckc · Pull Request #64 · dckc/finquick
faucet/src/gift.js at 35c4bb7234577df166cf6c08518b5f8c4e43115a · Agoric/faucet
How to make an agoric address using cosmjs? · Agoric/agoric-sdk · Discussion #5830
cosmjs/packages/tendermint-rpc/src/rpcclients/httpclient.ts at main · cosmos/cosmjs
Example of using CosmJS with protobufjs to encode a custom proto message
SigningStargateClient | @cosmjs/stargate Documentation
Network change: Instituting fees on the Agoric chain to mitigate spam transactions - General / Announcements - Agoric Community Forum
ui-kit/packages/rpc/src/batchQuery.ts at main · Agoric/ui-kit
devnet.api.agoric.net/agoric/vstorage/data/published.agoricNames.brand?18595
Internet of Blockchains - Cosmos Network
feat: inter-tool bid list by dckc · Pull Request #7939 · Agoric/agoric-sdk
Smart Wallet Dapp Architecture | Documentation

0xpatrickdev · 2023-11-22T02:21:21Z

#64 (comment)

How were you able to get around this?

0xpatrickdev · 2023-11-22T02:33:37Z

packages/fincaps/src/batchQuery.js

+   */
+  const getJSON = (href, options = {}) => {
+    const opts = {
+      keepalive: true,


What does LCD stand for?

Also, curious why you are choosing to use keepalive? My MDN search is not providing helpful clues for this context

The keepalive option can be used to allow the request to outlive the page. Fetch with the keepalive flag is a replacement for the Navigator.sendBeacon() API.

LCD = Light client daemon

I copied keepAlive from something else... IOU some git spelunking.

0xpatrickdev · 2023-11-22T03:01:47Z

packages/fincaps/src/smartWallet.js

+
+  for await (const record of history) {
+    // TODO: mustMatch(record, OfferStatusShape)
+    if (record.updated === 'offerStatus' && record.status.id === id) {


This is a really helpful pattern

0xpatrickdev · 2023-11-22T03:05:23Z

packages/fincaps/src/offerSigner.js

+};
+
+/** @param {import('./secret-tool').PassKey} item */
+const fromPassKey = async item => {


What is PassKey? It seems like secret-tool.js wasn't checked in.... Does this read from a YubiKey? Or does secret-tool just get a secret from process.env?

it's there: secret-tool.js

It lets you access the FreeDesktop Secret Sevice, analogous to keychain.

from the package readme:

Plugins with POLA: Google Sheets, Desktop Secrets, sqlite3

Each of these plugins provdes POLA-shaped access:

...

secret-tool.js - SecretTool.makePasskey(attrs1)
makes a PassKey. From there, E(p).subKey(attrs2)
attenuates access to items with { ...attrs2, ...attrs1 }.

0xpatrickdev · 2023-11-22T03:41:51Z

Finally got around to reading this, looks awesome! I would like to port this to gimix, but am not sure I understand how we can preserve all of the security properties created here in the REST api context.

Some questions (from a novice endo-er):

does everything need a compartment? Or just the privileged resources
a. should the fastify instance (makeApp) go in its own compartment?
b. should different fastify “route groups” go in different compartments?
i.e., oracelAccept, sendJobReport, and ghOauth require different powers
where do we grant powers?
a. is there one entry point, or should we make multiple entry points? (In current gimix, there’s just one entry point and one resource (fastify app) created)
b. would the fastify app ever call the steps to load a wallet / signer, or would we just give it a pointer to a highly scoped (yet powerful) function like signAndSubmitJobOfferReport

dckc · 2023-11-22T09:49:44Z

How were you able to get around [SES_EVAL_REJECTED in protobufjs]?

with --UNSAFE :-/

The protobuf code is fundamentally just moving bits around in memory; it has no need for I/O etc. It's a perfect candidate to run fully confined. But it looks like it might do a direct eval, so I'm running it un-confined, with all the ambient authority of normal node code.

kumavis · 2023-11-29T19:24:10Z

eval in protobufjs https://github.com/protobufjs/protobuf.js/blob/4436cc748c19b88977ab0dc84e59c42339e00520/README.md?plain=1#L690

so far, needs to be an --UNSAFE plugin due to SES_EVAL_REJECTED in protobufjs

2023-08-16 7cf64bb

- port to .js

2023-11-03 b269131

This reverts commit 568c38d.

This reverts commit 3911dcc.

This reverts commit 4db7401.

This reverts commit 72812d7.

This reverts commit f0b8cd9.

- use ERef<RpcClient>, EREf(LCD)

dckc · 2024-03-17T23:54:08Z

overtaken by

feat(ag-trade): fetch, (un)marshal, lookup, sign... add to reserve endojs/playground#2

build(fincaps): cosmjs, @agoric/cosmic-proto

f0b8cd9

dckc force-pushed the ag-offer-sign branch 2 times, most recently from a4de447 to 4db7401 Compare November 19, 2023 22:40

dckc mentioned this pull request Nov 20, 2023

Implement ocapn ByteArray as a passStyleOf recognized immutable byte array. endojs/endo#1331

Open

0xpatrickdev reviewed Nov 22, 2023

View reviewed changes

dckc added 15 commits December 3, 2023 01:29

lock packages with cosmjs

ad08f4d

feat: offerSigner endo plug-in

3fdbf2a

feat: hdWallet endo plugin / module

9a2d21d

so far, needs to be an --UNSAFE plugin due to SES_EVAL_REJECTED in protobufjs

feat: smartWallet endo component

e5ab30f

feat: RpcClient using explicit access to the network

7c75850

test: replay fetch() utility

99828cc

test: regen fixture

ba233b4

docs: send-tokens with endo (Makefile target)

07b7ae0

chore: borrow marshal.ts from ui-kit

681ad63

2023-08-16 7cf64bb

fix: static mutable state in marshalTables

eb5dc48

- port to .js

chore: copy batchQuery.ts from ui-kit

41c0c51

2023-11-03 b269131

chore: port batchQuery to .js

0ecd58c

test: regenerate snapshots

31e1f84

feat!: add makeQueryTool to smartwallet (rename makeTxTool)

cc7f90e

docs: lookup IST brand from agoricNames

ee82368

dckc added 26 commits December 3, 2023 01:29

SQUASHME: move test-smartWallet

2fdb4c0

SQUASHME: move web-fixture

3b0b25b

Revert "docs: reserve-add demo using smartWallet.js"

cb51fc5

This reverts commit 568c38d.

Revert "docs: lookup IST brand from agoricNames"

e802ef6

This reverts commit 3911dcc.

Revert "docs: send-tokens with endo (Makefile target)"

c3192fa

This reverts commit 4db7401.

SQUASHME: rever send-tokens Makefile target (docs)

ee277ac

Revert "build: @agoric/smart-wallet devDependencies (types)"

93df2c6

This reverts commit 72812d7.

Revert "build(fincaps): cosmjs, @agoric/cosmic-proto"

6538c9c

This reverts commit f0b8cd9.

WIP: inter bid

bd9d2e6

WIP: copy makefile

0c9dc2a

WIP: copy packages

bc80aa3

WIP: lock packages

328528f

SQUASHME: batchQuery: make mapHistory more robust

eb36d07

feat(smartWallet): walletView

2dfae78

feat: separate fetch worker from smartWallet worker

f8b9a5c

- use ERef<RpcClient>, EREf(LCD)

SQUASHME: prune offerSigner design alternative

0d52ec4

SQUASHME: prune test-sign snapshots

d1ce327

fixup! test: replay fetch() utility

8ae16d6

SQUASHME: finish smartWallet recording test

c92d442

CHORE: regenearte test-smartWallet snapshots

b5e06d4

fixup! test: regen fixture

2221c11

SQUASHME: test-query

8b41ed0

SQUASME: web fixture

57db64c

XXX recording should be at RPC/LCD level, not fetch

1b74a11

SQUASHME smartWallet.js export WalletView type

831f365

WIP: refactor bid list to take an ERef<WalletView>

e1c5592

dckc force-pushed the ag-offer-sign branch from e1672ff to e1c5592 Compare December 3, 2023 07:35

dckc mentioned this pull request Jan 9, 2024

caplets for trading with the Agoric smartWallet endojs/playground#1

Closed

dckc closed this Mar 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agoric offer signer endo maker #64

Agoric offer signer endo maker #64

dckc commented Nov 19, 2023 •

edited

dckc commented Nov 19, 2023

dckc commented Nov 19, 2023

dckc commented Nov 20, 2023

dckc commented Nov 20, 2023

0xpatrickdev commented Nov 22, 2023

0xpatrickdev Nov 22, 2023

dckc Nov 22, 2023

0xpatrickdev Nov 22, 2023

0xpatrickdev Nov 22, 2023

dckc Nov 22, 2023

0xpatrickdev commented Nov 22, 2023

dckc commented Nov 22, 2023

kumavis commented Nov 29, 2023

dckc commented Mar 17, 2024

Agoric offer signer endo maker #64

Agoric offer signer endo maker #64

Conversation

dckc commented Nov 19, 2023 • edited

dckc commented Nov 19, 2023

SES_EVAL_REJECTED in protobufjs

dckc commented Nov 19, 2023

signing client can sendTokens

dckc commented Nov 20, 2023

endo smartWallet plugin can query vstorage, execute offers

dckc commented Nov 20, 2023

0xpatrickdev commented Nov 22, 2023

0xpatrickdev Nov 22, 2023

Choose a reason for hiding this comment

dckc Nov 22, 2023

Choose a reason for hiding this comment

0xpatrickdev Nov 22, 2023

Choose a reason for hiding this comment

0xpatrickdev Nov 22, 2023

Choose a reason for hiding this comment

dckc Nov 22, 2023

Choose a reason for hiding this comment

Plugins with POLA: Google Sheets, Desktop Secrets, sqlite3

0xpatrickdev commented Nov 22, 2023

dckc commented Nov 22, 2023

kumavis commented Nov 29, 2023

dckc commented Mar 17, 2024

dckc commented Nov 19, 2023 •

edited

signing client can `sendTokens`