Exchange based demands #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josipbagaric
approved these changes
Apr 2, 2020
| }); | ||
| }); | ||
|
|
||
| it('should be able to cancel demand', async () => { |
There was a problem hiding this comment.
Cancelling === Pausing demand?
There was a problem hiding this comment.
Yes, typo, should be "pause demand"
| @@ -15,3 +15,9 @@ export enum Unit { | |||
| GW = 1e9, | |||
| GWh = 1e9 | |||
| } | |||
|
|
|||
| export enum DemandStatus { | |||
There was a problem hiding this comment.
Can this be moved to the exchange-core package?
There was a problem hiding this comment.
I though so too, but exchange-core does not have any notion of the demand, it's bids, asks, orders, trades. Demand is a collection of bids.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the API for demands management, API for orders cancellation
Features:
Known issue where consecutive pause/resume/pause with less that ~1sec demand might end up with orders having wrong states #765