feat: new icon component usage logic #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, to use icon in
<MenuItem/>
, you have to provide icon component in list that goes withitems
prop of<HoldMenu/>
component like below.Now I decided to create animated icon component and use it in every
<MenuItem/>
. So only thing to do is providing an Icon component to<HoldMenuProvider/>
and in the menu list, just set the name of the icon. It is possible to use Reanimated for the props for styles of the icon. I noticed that this made the animations little bit more performant. New usage is like below.Cons
So far I worked with the 'react-native-vector-icons' for the example project. I will try to use expo vector icons as well and try to make it work.