Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FB-675] Removed Encryption and Decryption from Environment Vars #439

Merged
merged 1 commit into from Apr 14, 2020

Conversation

pasanchamikara
Copy link
Contributor

Description of your patch

Removes code from env_vars helper file which were used in Encryption and Decryption scnearios

Recommended Release Notes

Removed the encryption and decryption code blocks from the helper module pf ey-libs, such that it doesn't affect the overall functionality of the cookbooks.

Estimated risk

Low - Nothing majorly included

Components involved

ey-libs env-vars helper module

Description of testing done

  • Created a new branch with the changes made on ey-libs helper module.
  • Created a new labrea release with that branch
  • Changed the environment to a production stack and added a few environment variables.
  • Added environment variables via the dashboard and changed the stack back to development stack.
  • Environment-wide apply made and checked if the environment variables are working properly.

QA Instructions

Book a PHP and rails environments separately and add environment variables via the dashboard. Check env.cloud file to see if the values are set as expected.

@jfuechsl jfuechsl added the LGTM label Jan 20, 2020
@jfuechsl jfuechsl merged commit 990d029 into next-release Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants