Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source files from distribution #96

Merged
merged 3 commits into from
Aug 22, 2017
Merged

Remove source files from distribution #96

merged 3 commits into from
Aug 22, 2017

Conversation

bash
Copy link

@bash bash commented Aug 16, 2017

The babel config should probably not be exposed in the package published on npm (which can lead to annoyances when using bundlers like rollup with babel).

I have extracted the config from the package.json into a .babelrc and excluded it from being released with the package.

@englercj
Copy link
Owner

It needs to be exposed because I ship the source (src/) folder, and so how to build it needs to go out as well. There is an argument to be made for not shipping the source either, I guess if that is what you want?

Also: no need for .npmignore since we have "files" specified in the package.json

@bash
Copy link
Author

bash commented Aug 21, 2017

There is an argument to be made for not shipping the source either, I guess if that is what you want?

Yes that is what I had in mind.
Considering this is not what my PR does, should I close it?


...(which can lead to annoyances when using bundlers like rollup with babel).

I have since found a solution for this in the README of the babel plugin for rollup: https://github.com/rollup/rollup-plugin-babel#external-dependencies (Well done me for not looking there in the first place)

@englercj
Copy link
Owner

If you wanted to change this PR to use .babelrc and not ship source I'm good with that. Remember to modify the files property in package.json rather than using .npmignore.

@bash bash changed the title Extract babel config into .babelrc Remove source files from distribution Aug 22, 2017
Copy link
Owner

@englercj englercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@englercj englercj merged commit a62d29b into englercj:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants