Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Editor Layout Improvements #156

Merged
merged 5 commits into from Aug 24, 2020
Merged

Conversation

RobertBColton
Copy link
Contributor

@RobertBColton RobertBColton commented Aug 22, 2020

Bringing some of my layout improvements from #144 over to master as their own changes.

  • Changes properties layout from vbox to form so it has two columns where that's needed like the name field.
  • Adds the name label and a buddy field.
  • Maps the name field to the tree node.
  • Changes the tileset groupbox to fixed vertical size policy.
Master Pull
Master Background Editor Properties Layout Pull Request Background Editor Properties Layout

What's odd is the layout looks different on master in the designer than it does at runtime. At runtime the editor above looks like there is a vertical spacer inside the tileset groupbox pushing them all to the top.
Master Background Editor Designer Properties Layout

@@ -108,24 +111,24 @@
<property name="bottomMargin">
<number>4</number>
</property>
<item>
<item row="1" column="0" colspan="2">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shit's worse than SVG, honestly.

<property name="text">
<string>&amp;Name</string>
</property>
<property name="buddy">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "buddy"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buddy is where if you press the mnemonic key of the label the buddy is focused. That's why the N is underlined in GameMaker.

GM Label Buddy

@RobertBColton RobertBColton merged commit b597046 into master Aug 24, 2020
@RobertBColton RobertBColton deleted the background-editor-layout branch August 24, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants