Tileset Label Alignment #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JoshDreamland in #157 did not want me to right align the sprite bbox labels, so I am proposing to change the background frame's to be left aligned for consistency. I've done some more research and I think I can now articulate why Josh is correct in our specific case.
Yes it's true that the Gestalt principles of grouping are why right-aligned labels are easier to scan when you are filling out a sequential web form from top to bottom. However, left-aligned labels do work better where the user is scanning for just one field by name which they already know in advance. The latter is what we have in ENIGMA's case, as these fields are not really intended to be entered sequentially, or even changed from the default. The user typically comes into these editors looking to just change one or two of the fields for which they already know the name.