-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only 142 tries (so far) #87
Conversation
[skip ci]
azure-pipelines.yml
Outdated
- task: GithubRelease@0 | ||
displayName: 'Create GitHub Release' | ||
inputs: | ||
gitHubConnection: github.com_fundies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update this once we setup azure
azure-pipelines.yml
Outdated
gitHubConnection: github.com_fundies | ||
repositoryName: fundies/RadialGM | ||
tagSource: manual | ||
tag: RadialGM-$(Date:yyyyMMdd)$(Rev:.r) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobertBColton any idea how I can make this match up with appveyor's tag? Cause my only idea is using date but I don't like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with just $Rev? All we'd need is shared environment variable. If that's not doable Josh said before it's ok to check it into a text file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and how is appveyor going to know what azxure's $rev var is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what $rev is, can you tell me? It used to be used in LGM's about dialog too.
IsmAvatar/LateralGM@76e25f9
I removed it assuming it was an artifact of SVN and replaced it with a static string of LGM's version number so I could update the version number easier and uniformly.
The about box was never even interpolating the string until I added the LGM version number, so I don't know why $rev was in there.
IsmAvatar/LateralGM@4485531#diff-ba968f27b8884ee0b10bb66ad787ba0e
You think Gandhi gave up after 142 tries? Well I got news for you, he gave up after 241 tries. You're only halfway there. |
@RobertBColton or @JoshDreamland you can review n merge this it appears to work now. The deploy is untested though cause its a PR. Also the msys build appear to be broken (they compile but segfault) but I think its just a grpc bug. |
@JoshDreamland so I got mingw working too so you can disable appveyor for this repo when you merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool; good work. Looks like you had a lot of fun. I'm jealous.
Good to go I think