Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declared directory_destroy() / _rename() / _copy() #1073

Closed
wants to merge 2 commits into from
Closed

Declared directory_destroy() / _rename() / _copy() #1073

wants to merge 2 commits into from

Conversation

time-killer-games
Copy link
Contributor

@time-killer-games time-killer-games commented Sep 20, 2017

This commit is for completing the changes I made to WINDOWSfilemanip.cpp

This is commit is for completing the changes I made to WINDOWSfilemanip.cpp
@RobertBColton
Copy link
Contributor

This is perfect, but you have to go and update all the *.cpp files so that it says directory_destroy too. You don't really have to test it, but just go into the Mac, Windows, and Linux source files and make sure the name is updated or else there will be an error if you try to use it.

@time-killer-games
Copy link
Contributor Author

@RobertBColton Thanks man! How do I do that without making a new pull request? i.e. append it to an existing one? I know how to do that if I'm editing the same file, but not if the file I'm editing is different from the ones in existing pull requests.

@RobertBColton
Copy link
Contributor

Did you make these changes through GitHub or did you use "git clone" to clone your fork to the desktop?

What you do is fork it to your account on here. Use a git command line to "git clone http/url/for/your/fork" to the desktop or some folder you keep your projects. You make your changes then use git add and then git commit to create a commit. You can create as many commits locally on your computer as you want. When you get everything to where you want, you use git push to send those commits up to your fork on GitHub then you initiate a pull request from your fork to the main repo. Since you already have a PR here where we are talking, I assume you already did this or made the changes on GitHub. To add more changes you just make more commits, meaning you just repeat the same process and push the changes or keep editing your repo on GitHub and it will automatically append them to this PR.

@RobertBColton RobertBColton added the Platforms Win32, Xlib, Cocoa, SDL and other target platforms. label Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platforms Win32, Xlib, Cocoa, SDL and other target platforms.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants